You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/11/01 18:38:02 UTC

[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #331: omega-edit updates

Shanedell opened a new pull request, #331:
URL: https://github.com/apache/daffodil-vscode/pull/331

   omega-edit updates:
   
   - Update version from 0.9.20 to 0.9.21
   - Update viewport subscribe to work for new version
     - "data" function not called immediately anymore, so we need to make sure the data is when setting up subscribtions.
   
   Closes #322


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301154134

   The recommendation we've gotten in the past during incubation is to not include extra information in NOTICE files, even if it's to keep track of files that have no NOTICE.
   
   This does adds difficulty when trying to keep track of which are missing and which just don't have a notice. Maybe we can figure out an alternative approach instead of keeping that information in the notice file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301146379

   > +1
   > 
   > Changes look reasonable. Though it looks like there are a number of new dependencies, I assume pulled in by the new version of omega edit? Have those been verified to be ASF compatible and updates made to the `build/package/{NOTICE,LICENSE}` files?
   
   @stevedlawrence I do need to update that, will do it in this PR before merging it. I know some were using Apache licensing without a notice in there repo. Can these possibly still be listed inside of the `build/package/NOTICE` and just do something like this
   
   ```
   - '@grpc/grpc-js' packaged in extension/dist/ext/extension.js
     NOTICE not provided. See repo at https://github.com/grpc/grpc-node/tree/master
   ```
   
   so that we know which dependencies are not known to be a part of the LICENSE or NOTICE? Also making sure we don't keep rechecking dependencies that we know are approved but just aren't marked down somewhere?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on code in PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#discussion_r1012169482


##########
yarn.lock:
##########
@@ -2,6 +2,13 @@
 # yarn lockfile v1
 
 
+"@cspotcode/source-map-support@^0.8.0":

Review Comment:
   Actually. I take it back. It may be that you want to keep the yarn.lock file, as it captures existing dependencies so one can detect changes to dependencies.  It gets regenerated, so keep in the tree if you see fit. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1302407645

   Create issue #333 to handle the tracking of the node dependencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301517270

   @stevedlawrence @mbeckerle So a I think there is a good chunk of the `yarn.lock` file dependencies that are possibly not in the LICENSE or NOTICE. Would you guys be okay with me merging this PR in and creating another ticket to make sure all dependencies inside of `yarn.lock` are in the LICENSE, NOTICE or NONOTICE (will be created as part of that PR) files before a possible 1.2.0 release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301929249

   Fine with me, please create a new issue so we don't forget about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#discussion_r1012188157


##########
yarn.lock:
##########
@@ -2,6 +2,13 @@
 # yarn lockfile v1
 
 
+"@cspotcode/source-map-support@^0.8.0":

Review Comment:
   @mbeckerle Yes I believe this was the reason we added it, was to ensure from developer to developer you make sure the dependencies are the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
Shanedell commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301225247

   > Maybe create a NONOTICE file to list these.
   
   I would be okay with doing this @stevedlawrence do you think this would be okay to do? Put it in the same location as the release NOTICE and LICENSE at `build/package`, however not actually bundle it inside of the release?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301350252

   Fine with me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] mbeckerle commented on pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#issuecomment-1301156316

   Maybe create a NONOTICE file to list these.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] Shanedell merged pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #331: omega-edit updates

Posted by GitBox <gi...@apache.org>.
mbeckerle commented on code in PR #331:
URL: https://github.com/apache/daffodil-vscode/pull/331#discussion_r1012165053


##########
yarn.lock:
##########
@@ -2,6 +2,13 @@
 # yarn lockfile v1
 
 
+"@cspotcode/source-map-support@^0.8.0":

Review Comment:
   This file should not be checked in at all. Please add it to .gitignore so it doesn't get committed by accident again. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org