You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2026/01/10 02:47:38 UTC

[PR] Jdbc realm config [polaris]

dimas-b opened a new pull request, #3412:
URL: https://github.com/apache/polaris/pull/3412

   <!--
   ๐Ÿ“ Describe what changes you're proposing, especially breaking or user-facing changes. 
   ๐Ÿ“– See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   ## Checklist
   - [ ] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact security@apache.org)
   - [ ] ๐Ÿ”— Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [ ] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and explained how)
   - [ ] ๐Ÿ’ก Added comments for complex logic
   - [ ] ๐Ÿงพ Updated `CHANGELOG.md` (if needed)
   - [ ] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use injected RealmConfig in JdbcMetaStoreManagerFactory [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3412:
URL: https://github.com/apache/polaris/pull/3412#issuecomment-3756636336

   @singhpk234 : Do you have any feedback on this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use injected RealmConfig in JdbcMetaStoreManagerFactory [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3412:
URL: https://github.com/apache/polaris/pull/3412#discussion_r2690939472


##########
runtime/admin/src/main/java/org/apache/polaris/admintool/config/AdminToolProducers.java:
##########
@@ -75,4 +77,10 @@ public PolarisConfigurationStore configurationStore() {
     // A configuration store is not required when running the admin tool.
     return new PolarisConfigurationStore() {};
   }
+
+  @Produces
+  public RealmConfig dummyRealmConfig(PolarisConfigurationStore configurationStore) {
+    // Use "unknown" realm ID for RealmConfig since the PolarisConfigurationStore is empty anyway
+    return new RealmConfigImpl(configurationStore, () -> "unknown");

Review Comment:
   updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use injected RealmConfig in JdbcMetaStoreManagerFactory [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3412:
URL: https://github.com/apache/polaris/pull/3412#issuecomment-3731661811

   Draft for now as this PR depends on #3324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use injected RealmConfig in JdbcMetaStoreManagerFactory [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #3412:
URL: https://github.com/apache/polaris/pull/3412#discussion_r2690009025


##########
runtime/admin/src/main/java/org/apache/polaris/admintool/config/AdminToolProducers.java:
##########
@@ -75,4 +77,10 @@ public PolarisConfigurationStore configurationStore() {
     // A configuration store is not required when running the admin tool.
     return new PolarisConfigurationStore() {};
   }
+
+  @Produces
+  public RealmConfig dummyRealmConfig(PolarisConfigurationStore configurationStore) {
+    // Use "unknown" realm ID for RealmConfig since the PolarisConfigurationStore is empty anyway
+    return new RealmConfigImpl(configurationStore, () -> "unknown");

Review Comment:
   Would this be a problem if a realm with this exact name actually existed? Maybe a special `RealmConfig` implementation would be more appropriate?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use injected RealmConfig in JdbcMetaStoreManagerFactory [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3412:
URL: https://github.com/apache/polaris/pull/3412#discussion_r2690657078


##########
runtime/admin/src/main/java/org/apache/polaris/admintool/config/AdminToolProducers.java:
##########
@@ -75,4 +77,10 @@ public PolarisConfigurationStore configurationStore() {
     // A configuration store is not required when running the admin tool.
     return new PolarisConfigurationStore() {};
   }
+
+  @Produces
+  public RealmConfig dummyRealmConfig(PolarisConfigurationStore configurationStore) {
+    // Use "unknown" realm ID for RealmConfig since the PolarisConfigurationStore is empty anyway
+    return new RealmConfigImpl(configurationStore, () -> "unknown");

Review Comment:
   Well, the underlying config is empty, so the name cannot match anything.
   
   I'll change it to random to be sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use injected RealmConfig in JdbcMetaStoreManagerFactory [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #3412:
URL: https://github.com/apache/polaris/pull/3412


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org