[GitHub] [accumulo] Manno15 commented on a change in pull request #2087: Fix #2070 address ShellServerIT test failures

[GitBox <gi...@apache.org>]

Manno15 commented on a change in pull request #2087:
URL: https://github.com/apache/accumulo/pull/2087#discussion_r629334242



##########
File path: test/src/main/java/org/apache/accumulo/test/ShellServerIT.java
##########
@@ -1421,21 +1431,24 @@ public void help() throws Exception {
     }
   }
 
+  // TODO - evaluate this test is testing what is expected or history is working.
   @Test
   public void history() throws Exception {
     final String table = name.getMethodName();
 
     ts.exec("history -c", true);
     ts.exec("createtable " + table);
     ts.exec("deletetable -f " + table);
+    // TODO - this may be passing only because method name is history.

Review comment:
       There does appear to be an issue with the history test. Changing the name of the table does result in a test failure. I am not quite sure if it has to do with the history command itself or with the way we search for the expectedString. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org