You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 10:12:54 UTC
[GitHub] [arrow] raulcd opened a new pull request, #12882: Minor: update to nightly reports individual job URLs
raulcd opened a new pull request, #12882:
URL: https://github.com/apache/arrow/pull/12882
We currently have around 86K branches on the crossbow repository. This causes some direct problems on browsing and the email reports queries sometimes failing to open.
There are some initiatives to reduce the number of branches (https://github.com/ursacomputing/crossbow/pull/12) both to improve the browsing experience and to avoid possible issues with Github.
One small improvement I propose is to update the URLs on our nightly report emails for individual tasks to avoid a search on github that might timeout.
Instead of using:
https://github.com/ursacomputing/crossbow/branches/all?query=nightly-tests-2022-04-14-0-github-test-build-vcpkg-win
Using the direct branch URL to avoid the search:
https://github.com/ursacomputing/crossbow/tree/nightly-tests-2022-04-14-0-github-test-build-vcpkg-win
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12882: Minor: update to nightly reports individual job URLs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12882:
URL: https://github.com/apache/arrow/pull/12882#issuecomment-1099016571
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #12882: MINOR: [CI] update to nightly reports individual job URLs
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #12882:
URL: https://github.com/apache/arrow/pull/12882#discussion_r850459231
##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -173,10 +173,15 @@ def url(self, query):
repo_url = self.job.queue.remote_url.strip('.git')
return '{}/branches/all?query={}'.format(repo_url, query)
+ def branch_url(self, branch):
+ repo_url = self.job.queue.remote_url.strip('.git')
Review Comment:
This isn't correct:
```python
>>> "something".strip(".git")
'somethin'
```
Starting with Python 3.9 you can use [`str.removesuffix`](https://docs.python.org/3/library/stdtypes.html#str.removesuffix), but for now you'll need something like:
```python
@property
def repo_url(self):
url = self.job.queue.remote_url
return url[:-4] if url.endswith('.git') else url
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on a diff in pull request #12882: MINOR: [CI] update to nightly reports individual job URLs
Posted by GitBox <gi...@apache.org>.
raulcd commented on code in PR #12882:
URL: https://github.com/apache/arrow/pull/12882#discussion_r850470351
##########
dev/archery/archery/crossbow/reports.py:
##########
@@ -173,10 +173,15 @@ def url(self, query):
repo_url = self.job.queue.remote_url.strip('.git')
return '{}/branches/all?query={}'.format(repo_url, query)
+ def branch_url(self, branch):
+ repo_url = self.job.queue.remote_url.strip('.git')
Review Comment:
Thanks for that, I did copy&paste from the existing url extraction, I have modified the original one (https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/reports.py#L173) to solve that issue too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12882: MINOR: [CI] update to nightly reports individual job URLs
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12882: MINOR: [CI] update to nightly reports individual job URLs
URL: https://github.com/apache/arrow/pull/12882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12882: MINOR: [CI] update to nightly reports individual job URLs
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12882:
URL: https://github.com/apache/arrow/pull/12882#issuecomment-1100446748
Benchmark runs are scheduled for baseline = 69c28de89557b413907b07633c9b74318f16b813 and contender = ff8018232ee3aa14be16c7afeafc54637741a14c. ff8018232ee3aa14be16c7afeafc54637741a14c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f2f83a723db846b4861e18da33b8c458...b00422f55f8a4f9690b230acc0f0d472/)
[Finished :arrow_down:0.25% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/6566c484b8494ae6868ae6867dd2efc2...76ecb0bcc8044ba891b932baba7ab858/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/455e0b5ee73e4569bf1651b0567b90e9...9224a847dfc4496f97e3fae3b8081c69/)
[Finished :arrow_down:0.34% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c47551cdd92c4f08abb29b4dd2a9b8f2...93a65384fac14ab897cd937d6d27b8b0/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/515| `ff801823` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/502| `ff801823` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/501| `ff801823` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/512| `ff801823` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/514| `69c28de8` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/501| `69c28de8` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/500| `69c28de8` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/511| `69c28de8` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #12882: MINOR: [CI] update to nightly reports individual job URLs
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #12882:
URL: https://github.com/apache/arrow/pull/12882#issuecomment-1099213444
I will create a ticket to add tests to archery and crossbow. I have tested the report locally to validate the URLs are correct:
```
$ archery crossbow report --no-fetch nightly-packaging-2022-04-14-0
From: None <None>
To: None
Subject: [NIGHTLY] Arrow Build Report for Job nightly-packaging-2022-04-14-0
Arrow Build Report for Job nightly-packaging-2022-04-14-0
All tasks: https://github.com/raulcd/crossbow/branches/all?query=nightly-packaging-2022-04-14-0
Errored Tasks:
- debian-bookworm-arm64:
URL: https://github.com/raulcd/crossbow/tree/nightly-packaging-2022-04-14-0-travis-debian-bookworm-arm64
- nuget:
URL: https://github.com/raulcd/crossbow/tree/nightly-packaging-2022-04-14-0-github-nuget
- wheel-windows-cp310-amd64:
URL: https://github.com/raulcd/crossbow/tree/nightly-packaging-2022-04-14-0-github-wheel-windows-cp310-amd64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org