You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2018/10/26 19:05:08 UTC

[GitHub] [geode] jinmeiliao opened pull request #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

* break the test into dunit and integration tests
* use the rules to better see what's the setup and what the test is doing

No functional changes to the tests. This to prepare debugging the test in Jdk11. This way, we can better reasoning what's happening in the test.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Minor, but I'd change this name to not have `*TestBase` in it, since we're not in that gnarly test base class anymore.  (Another below.)

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
The refactored tests are at most as flaky as the old one. Ran streeTest on old tests and get a lot more failures: https://github.com/apache/geode/pull/2745. I think we can call this refactor good.

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on pull request #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
There are a handful of places in the tests where, for instance, IntelliJ's inspections can identify where the old iterator style is used where the more readable `for each` loop style could be used instead.  A minor thing, but as long as the focus is refactoring, it's an easy thing to let your IDE do.

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
Add back this copyright header

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
The refactored tests are at most as flaky as the old one. Ran stressTest on old tests and get a lot more failures: https://github.com/apache/geode/pull/2745. I think we can call this refactor good.

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #2734: GEODE-5943: Refactor EvictionDUnitTest and OffHeapEvictionDUnitTest

Posted by "dschneider-pivotal (GitHub)" <gi...@apache.org>.
Add a copyright header to this new file

[ Full content available at: https://github.com/apache/geode/pull/2734 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org