You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Damjan Jovanovic <da...@apache.org> on 2012/07/24 03:18:36 UTC
[VOTE] Release Imaging 1.0 based on RC2
It's been 3 years since Imaging 0.97 was released,
and many bugs have been fixed and many features added,
so I would like to release a long overdue Imaging 1.0.
Imaging 1.0, RC2 is available for review here:
http://people.apache.org/~damjan/imaging-1.0-RC2/
Maven artifacts are here:
http://people.apache.org/~damjan/imaging-1.0-RC2/maven
Details of changes since 0.97 are in the release notes:
http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
I have tested this with JDK 1.6 using maven2.
The tag is here:
http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
Site:
http://people.apache.org/~damjan/imaging-1.0-RC2/site/
Clirr Report is irrelevant - there is no source/binary/semantic
compatibility with 0.97.
RAT Report:
http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
Votes, please. This vote will close in 72 hours, Friday 27 July 2012
at 02:00 GMT.
[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...
Thank you!
Damjan Jovanovic
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by sebb <se...@gmail.com>.
On 27 July 2012 16:10, Damjan Jovanovic <da...@gmail.com> wrote:
> On Thu, Jul 26, 2012 at 2:00 PM, sebb <se...@gmail.com> wrote:
>> On 24 July 2012 02:18, Damjan Jovanovic <da...@apache.org> wrote:
>>> It's been 3 years since Imaging 0.97 was released,
>>> and many bugs have been fixed and many features added,
>>> so I would like to release a long overdue Imaging 1.0.
>>>
>>> Imaging 1.0, RC2 is available for review here:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/
>>>
>>> Maven artifacts are here:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>>
>> Commons components must use Nexus for staging Maven artifacts (and can
>> use it for non-Maven as well)
>>
>
> I use the release instructions on
> http://commons.apache.org/releases/prepare.html
> Are they wrong?
They are rather out of date.
> Why are they still the official instructions?
Because no-one has got around to fixing them.
> Regards
> Damjan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by Damjan Jovanovic <da...@gmail.com>.
On Thu, Jul 26, 2012 at 2:00 PM, sebb <se...@gmail.com> wrote:
> On 24 July 2012 02:18, Damjan Jovanovic <da...@apache.org> wrote:
>> It's been 3 years since Imaging 0.97 was released,
>> and many bugs have been fixed and many features added,
>> so I would like to release a long overdue Imaging 1.0.
>>
>> Imaging 1.0, RC2 is available for review here:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/
>>
>> Maven artifacts are here:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>
> Commons components must use Nexus for staging Maven artifacts (and can
> use it for non-Maven as well)
>
I use the release instructions on
http://commons.apache.org/releases/prepare.html
Are they wrong?
Why are they still the official instructions?
Regards
Damjan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by sebb <se...@gmail.com>.
On 24 July 2012 02:18, Damjan Jovanovic <da...@apache.org> wrote:
> It's been 3 years since Imaging 0.97 was released,
> and many bugs have been fixed and many features added,
> so I would like to release a long overdue Imaging 1.0.
>
> Imaging 1.0, RC2 is available for review here:
> http://people.apache.org/~damjan/imaging-1.0-RC2/
>
> Maven artifacts are here:
> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
Commons components must use Nexus for staging Maven artifacts (and can
use it for non-Maven as well)
> Details of changes since 0.97 are in the release notes:
> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
I think the release notes need to make it very clear that Imaging is
completely different from Sanselan.
They need to describe the:
- different package name
- different Maven co-ordinates.
> I have tested this with JDK 1.6 using maven2.
>
> The tag is here:
> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>
> Clirr Report is irrelevant - there is no source/binary/semantic
> compatibility with 0.97.
Agreed.
> RAT Report:
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
There are at least 3 package.html files without AL headers.
> Votes, please. This vote will close in 72 hours, Friday 27 July 2012
> at 02:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
-1
> Thank you!
>
> Damjan Jovanovic
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by Oliver Heger <ol...@oliver-heger.de>.
Build works fine on Windows 7 with a JDK 1.6 and Java-1.5 compatibility
profile. Artifacts look good.
There are some issues with the site:
- There is indeed a number of findbugs and pmd warnings. I trust you
that you already fixed many problematic ones. All these MALICIOUS_CODE
warnings are probably not relevant as the library has to do lots of
processing on arrays. However, all these DLS_DEAD_LOCAL_STORE warnings
seem to be suspicious. Are you sure, they should not be addressed?
- The RAT report has some missing licenses. For all these info.txt files
licenses are certainly not needed. But there are also a few package.html
files affected.
- Test coverage is partly very low, there are packages with 0 percent
coverage.
So, all in all I am +0
Oliver
Am 24.07.2012 03:18, schrieb Damjan Jovanovic:
> It's been 3 years since Imaging 0.97 was released,
> and many bugs have been fixed and many features added,
> so I would like to release a long overdue Imaging 1.0.
>
> Imaging 1.0, RC2 is available for review here:
> http://people.apache.org/~damjan/imaging-1.0-RC2/
>
> Maven artifacts are here:
> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>
> Details of changes since 0.97 are in the release notes:
> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
>
> I have tested this with JDK 1.6 using maven2.
>
> The tag is here:
> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>
> Clirr Report is irrelevant - there is no source/binary/semantic
> compatibility with 0.97.
>
> RAT Report:
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
>
> Votes, please. This vote will close in 72 hours, Friday 27 July 2012
> at 02:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you!
>
> Damjan Jovanovic
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DISCUSS] Release Imaging 1.0 based on RC2
Posted by Damjan Jovanovic <da...@gmail.com>.
On Tue, Jul 24, 2012 at 5:44 PM, Matt Benson <gu...@gmail.com> wrote:
> On Tue, Jul 24, 2012 at 1:31 AM, Damjan Jovanovic <da...@gmail.com> wrote:
>> On Tue, Jul 24, 2012 at 5:47 AM, Gary Gregory <ga...@gmail.com> wrote:
>>> On Jul 23, 2012, at 21:19, Damjan Jovanovic <da...@apache.org> wrote:
>>>
>>>> It's been 3 years since Imaging 0.97 was released,
>>>> and many bugs have been fixed and many features added,
>>>> so I would like to release a long overdue Imaging 1.0.
>>>>
>>>> Imaging 1.0, RC2 is available for review here:
>>>> http://people.apache.org/~damjan/imaging-1.0-RC2/
>>>>
>>>> Maven artifacts are here:
>>>> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>>>>
>>>> Details of changes since 0.97 are in the release notes:
>>>> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
>>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
>>>>
>>>> I have tested this with JDK 1.6 using maven2.
>>>>
>>>> The tag is here:
>>>> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>>>>
>>>> Site:
>>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>>>>
>>>> Clirr Report is irrelevant - there is no source/binary/semantic
>>>> compatibility with 0.97.
>>>
>>> Since this is 1.0, I am more concerned with getting the API right than
>>> compatibility with a sandbox version. My question therefore is: are
>>> you happy with the API?
>>>
>>> I am traveling ATM and cannot dig into my IDE.
>>>
>>> I took a peek at the reports and there are a lot of issues reported by
>>> FindBugs, PMD and so on. What is the plan there?
>>
>> The API is fine for now. It could use some improvements, but that's
>> something I'd rather leave for version 2.0.
>
> In that case, what timeframe are you thinking of for [imaging] v2?
>
Not long, maybe by the end of the year.
Damjan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DISCUSS] Release Imaging 1.0 based on RC2
Posted by Matt Benson <gu...@gmail.com>.
On Tue, Jul 24, 2012 at 1:31 AM, Damjan Jovanovic <da...@gmail.com> wrote:
> On Tue, Jul 24, 2012 at 5:47 AM, Gary Gregory <ga...@gmail.com> wrote:
>> On Jul 23, 2012, at 21:19, Damjan Jovanovic <da...@apache.org> wrote:
>>
>>> It's been 3 years since Imaging 0.97 was released,
>>> and many bugs have been fixed and many features added,
>>> so I would like to release a long overdue Imaging 1.0.
>>>
>>> Imaging 1.0, RC2 is available for review here:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/
>>>
>>> Maven artifacts are here:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>>>
>>> Details of changes since 0.97 are in the release notes:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
>>>
>>> I have tested this with JDK 1.6 using maven2.
>>>
>>> The tag is here:
>>> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>>>
>>> Site:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>>>
>>> Clirr Report is irrelevant - there is no source/binary/semantic
>>> compatibility with 0.97.
>>
>> Since this is 1.0, I am more concerned with getting the API right than
>> compatibility with a sandbox version. My question therefore is: are
>> you happy with the API?
>>
>> I am traveling ATM and cannot dig into my IDE.
>>
>> I took a peek at the reports and there are a lot of issues reported by
>> FindBugs, PMD and so on. What is the plan there?
>
> The API is fine for now. It could use some improvements, but that's
> something I'd rather leave for version 2.0.
In that case, what timeframe are you thinking of for [imaging] v2?
Matt
>
> I've already fixed all the FindBugs problems that are worth fixing,
> the rest are non-issues. The issues PMD finds (final modifiers in
> final classes, empty catch blocks, unused parameters) are things I
> consider normal.
>
>> Gary
>>
>>>
>>> RAT Report:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
>>>
>>> Votes, please. This vote will close in 72 hours, Friday 27 July 2012
>>> at 02:00 GMT.
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thank you!
>>>
>>> Damjan Jovanovic
>
> Damjan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by sebb <se...@gmail.com>.
On 24 July 2012 07:31, Damjan Jovanovic <da...@gmail.com> wrote:
> On Tue, Jul 24, 2012 at 5:47 AM, Gary Gregory <ga...@gmail.com> wrote:
>> On Jul 23, 2012, at 21:19, Damjan Jovanovic <da...@apache.org> wrote:
>>
>>> It's been 3 years since Imaging 0.97 was released,
>>> and many bugs have been fixed and many features added,
>>> so I would like to release a long overdue Imaging 1.0.
>>>
>>> Imaging 1.0, RC2 is available for review here:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/
>>>
>>> Maven artifacts are here:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>>>
>>> Details of changes since 0.97 are in the release notes:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
>>>
>>> I have tested this with JDK 1.6 using maven2.
>>>
>>> The tag is here:
>>> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>>>
>>> Site:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>>>
>>> Clirr Report is irrelevant - there is no source/binary/semantic
>>> compatibility with 0.97.
>>
>> Since this is 1.0, I am more concerned with getting the API right than
>> compatibility with a sandbox version. My question therefore is: are
>> you happy with the API?
>>
>> I am traveling ATM and cannot dig into my IDE.
>>
>> I took a peek at the reports and there are a lot of issues reported by
>> FindBugs, PMD and so on. What is the plan there?
>
> The API is fine for now. It could use some improvements, but that's
> something I'd rather leave for version 2.0.
There seem to be quite a few public arrays and collections; these are
prone to accidental or malicious updates.
Ideally all mutable fields should be private, or at worst package protected.
If access is needed, provide a getter.
Only constants should be protected or public.
It won't be possible to remove protected or public field qualifiers
without breaking compatibilty, so ideally lock down all fields now.
Reducing data exposure makes testing easier, as there are fewer cases
to consider, and classes can be more easily tested in isolation.
It also helps with thread-safety.
> I've already fixed all the FindBugs problems that are worth fixing,
> the rest are non-issues. The issues PMD finds (final modifiers in
> final classes, empty catch blocks, unused parameters) are things I
> consider normal.
>
>> Gary
>>
>>>
>>> RAT Report:
>>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
>>>
>>> Votes, please. This vote will close in 72 hours, Friday 27 July 2012
>>> at 02:00 GMT.
>>>
>>> [ ] +1 Release these artifacts
>>> [ ] +0 OK, but...
>>> [ ] -0 OK, but really should fix...
>>> [ ] -1 I oppose this release because...
>>>
>>> Thank you!
>>>
>>> Damjan Jovanovic
>
> Damjan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by Damjan Jovanovic <da...@gmail.com>.
On Tue, Jul 24, 2012 at 5:47 AM, Gary Gregory <ga...@gmail.com> wrote:
> On Jul 23, 2012, at 21:19, Damjan Jovanovic <da...@apache.org> wrote:
>
>> It's been 3 years since Imaging 0.97 was released,
>> and many bugs have been fixed and many features added,
>> so I would like to release a long overdue Imaging 1.0.
>>
>> Imaging 1.0, RC2 is available for review here:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/
>>
>> Maven artifacts are here:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>>
>> Details of changes since 0.97 are in the release notes:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
>>
>> I have tested this with JDK 1.6 using maven2.
>>
>> The tag is here:
>> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>>
>> Site:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>>
>> Clirr Report is irrelevant - there is no source/binary/semantic
>> compatibility with 0.97.
>
> Since this is 1.0, I am more concerned with getting the API right than
> compatibility with a sandbox version. My question therefore is: are
> you happy with the API?
>
> I am traveling ATM and cannot dig into my IDE.
>
> I took a peek at the reports and there are a lot of issues reported by
> FindBugs, PMD and so on. What is the plan there?
The API is fine for now. It could use some improvements, but that's
something I'd rather leave for version 2.0.
I've already fixed all the FindBugs problems that are worth fixing,
the rest are non-issues. The issues PMD finds (final modifiers in
final classes, empty catch blocks, unused parameters) are things I
consider normal.
> Gary
>
>>
>> RAT Report:
>> http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
>>
>> Votes, please. This vote will close in 72 hours, Friday 27 July 2012
>> at 02:00 GMT.
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>>
>> Thank you!
>>
>> Damjan Jovanovic
Damjan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [VOTE] Release Imaging 1.0 based on RC2
Posted by Gary Gregory <ga...@gmail.com>.
On Jul 23, 2012, at 21:19, Damjan Jovanovic <da...@apache.org> wrote:
> It's been 3 years since Imaging 0.97 was released,
> and many bugs have been fixed and many features added,
> so I would like to release a long overdue Imaging 1.0.
>
> Imaging 1.0, RC2 is available for review here:
> http://people.apache.org/~damjan/imaging-1.0-RC2/
>
> Maven artifacts are here:
> http://people.apache.org/~damjan/imaging-1.0-RC2/maven
>
> Details of changes since 0.97 are in the release notes:
> http://people.apache.org/~damjan/imaging-1.0-RC2/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/changes-report.html
>
> I have tested this with JDK 1.6 using maven2.
>
> The tag is here:
> http://svn.apache.org/viewvc/commons/proper/imaging/tags/IMAGING_1_0_RC2/
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/
>
> Clirr Report is irrelevant - there is no source/binary/semantic
> compatibility with 0.97.
Since this is 1.0, I am more concerned with getting the API right than
compatibility with a sandbox version. My question therefore is: are
you happy with the API?
I am traveling ATM and cannot dig into my IDE.
I took a peek at the reports and there are a lot of issues reported by
FindBugs, PMD and so on. What is the plan there?
Gary
>
> RAT Report:
> http://people.apache.org/~damjan/imaging-1.0-RC2/site/rat-report.html
>
> Votes, please. This vote will close in 72 hours, Friday 27 July 2012
> at 02:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you!
>
> Damjan Jovanovic
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org