You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by hw...@apache.org on 2012/02/01 04:50:40 UTC
svn commit: r1238931 - /subversion/trunk/subversion/include/svn_editor.h
Author: hwright
Date: Wed Feb 1 03:50:40 2012
New Revision: 1238931
URL: http://svn.apache.org/viewvc?rev=1238931&view=rev
Log:
* subversion/include/svn_editor.h
(svn_editor_set_text): Add a question.
Modified:
subversion/trunk/subversion/include/svn_editor.h
Modified: subversion/trunk/subversion/include/svn_editor.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_editor.h?rev=1238931&r1=1238930&r2=1238931&view=diff
==============================================================================
--- subversion/trunk/subversion/include/svn_editor.h (original)
+++ subversion/trunk/subversion/include/svn_editor.h Wed Feb 1 03:50:40 2012
@@ -885,6 +885,7 @@ svn_editor_set_props(svn_editor_t *edito
* with checksum @a checksum.
* ### TODO @todo Does this send the *complete* content, always?
* ### TODO @todo What is REVISION for?
+ * ### TODO @todo Who is responsible for closing the stream?
*
* For all restrictions on driving the editor, see #svn_editor_t.
* @since New in 1.8.
Re: svn commit: r1238931 - /subversion/trunk/subversion/include/svn_editor.h
Posted by Hyrum K Wright <hy...@wandisco.com>.
On Tue, Jan 31, 2012 at 11:01 PM, Greg Stein <gs...@gmail.com> wrote:
> On Tue, Jan 31, 2012 at 22:50, <hw...@apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/include/svn_editor.h Wed Feb 1 03:50:40 2012
>> @@ -885,6 +885,7 @@ svn_editor_set_props(svn_editor_t *edito
>> * with checksum @a checksum.
>> * ### TODO @todo Does this send the *complete* content, always?
>> * ### TODO @todo What is REVISION for?
>> + * ### TODO @todo Who is responsible for closing the stream?
>
> The receiver does. I'll clarify this in the docco after my API
> changes.
Yeah, I figured that's the answer, I just wasn't sure (and rather than
guess, I figured I'd record my uncertainty to ensure it gets clarified
at some point).
> The receiver has three choices:
>
> 1) close the stream without reading
> 2) close the stream after reading *some* of the content
> 3) close the stream after reading *all* the content
>
> Drivers should generally use a lazy-load technique in case of (1).
> They may not require disk access, resource consumption, etc, if the
> receiver choose to immediately close the stream.
>
> Example: the checksum already exists in the pristine store, so the
> receiver can immediately close the stream [rather than spooling the
> contents into the store].
>
> Cheers,
> -g
--
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Re: svn commit: r1238931 - /subversion/trunk/subversion/include/svn_editor.h
Posted by Greg Stein <gs...@gmail.com>.
On Tue, Jan 31, 2012 at 22:50, <hw...@apache.org> wrote:
>...
> +++ subversion/trunk/subversion/include/svn_editor.h Wed Feb 1 03:50:40 2012
> @@ -885,6 +885,7 @@ svn_editor_set_props(svn_editor_t *edito
> * with checksum @a checksum.
> * ### TODO @todo Does this send the *complete* content, always?
> * ### TODO @todo What is REVISION for?
> + * ### TODO @todo Who is responsible for closing the stream?
The receiver does. I'll clarify this in the docco after my API
changes. The receiver has three choices:
1) close the stream without reading
2) close the stream after reading *some* of the content
3) close the stream after reading *all* the content
Drivers should generally use a lazy-load technique in case of (1).
They may not require disk access, resource consumption, etc, if the
receiver choose to immediately close the stream.
Example: the checksum already exists in the pristine store, so the
receiver can immediately close the stream [rather than spooling the
contents into the store].
Cheers,
-g