You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/17 18:32:33 UTC
[GitHub] [airflow] kurtqq opened a new issue #12413: Description Field for Variables
kurtqq opened a new issue #12413:
URL: https://github.com/apache/airflow/issues/12413
add text column to explain what the variable is used for
same as https://github.com/apache/airflow/issues/10840 just for Variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] itroulli commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
itroulli commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-809696261
@kurtqq Tbh, that was indeed what I had in mind. So, I'll try to understand now, how the UI will be storing and retrieving the description content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] itroulli commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
itroulli commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-809668314
@kurtqq Sorry for the delay, I've been busy the past few days.
I had in mind some pieces of code like the import/export functions that treat variables as a key/value pair in which it would be required to change the struct to be able to import/export the description too. I might be wrong and have misunderstood something though. I'll try to give it a shot as soon as I find some time (first by skipping the description in functions like the import/export) and see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] itroulli commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
itroulli commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-809711707
According to my understanding, I'll have to create a file in `airflow/migrations/versions/` to add a column to the `variables` table but I'm not sure that I get how these files in the migrations folder work. Could you provide some resources?
Thanks in advance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] abhilash1in edited a comment on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
abhilash1in edited a comment on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-730178750
@kurtqq If you want to take a stab at it, I'll be happy to help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kurtqq commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
kurtqq commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-810562957
check https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#metadata-database-updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] xinbinhuang closed issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
xinbinhuang closed issue #12413:
URL: https://github.com/apache/airflow/issues/12413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kurtqq commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
kurtqq commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-730164368
@abhilash1in what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kurtqq commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
kurtqq commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-803517620
@itroulli why is it tricky? it's description per variable. it doesn't matter if the variable is text or key-value. the idea is to give general information to what the variable is used/who created it and stuff in that area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] abhilash1in commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
abhilash1in commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-730165229
That'll be useful, but I don't have the bandwidth for it right now, sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] abhilash1in commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
abhilash1in commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-730178750
If you want to take a stab at it, I'll be happy to help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kurtqq edited a comment on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
kurtqq edited a comment on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-809671348
@itroulli I see the description field as a column in the DB that we are able to edit in the UI. This is a meta column that just give the ability to document why the variable was created and stuff like that.
I don't think it should involved the key,value properties of how you access to variables. So if you thinking about doing something like changing`Variable.get()` I don't think this is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kurtqq commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
kurtqq commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-809671348
@itroulli I see the description field as a column in the DB that we are able to edit int he UI. This is a meta column that just give the ability to document why the variable was created and stuff like that.
I don't think it should involved the key,value properties of how you access to variables. So if you thinking about doing something like changing`Variable.get()` I don't think this is necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] itroulli edited a comment on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
itroulli edited a comment on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-801194346
@abhilash1in @eladkal I'm willing to dive into this as my first attempt to contribute if there is still interest. I'll probably need some help to start though. I think it's a bit more tricky than the Connection description as the Variables are mostly handled as a key-value pair.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] itroulli commented on issue #12413: Description Field for Variables
Posted by GitBox <gi...@apache.org>.
itroulli commented on issue #12413:
URL: https://github.com/apache/airflow/issues/12413#issuecomment-801194346
I'm willing to dive into this as my first attempt to contribute if there is still interest. I'll probably need some help to start though. I think it's a bit more tricky than the Connection description as the Variables are mostly handled as a key-value pair.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org