You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/07/02 05:38:51 UTC

[PR] [SPARK-57875] Exclude Hadoop `filecache` classes from shadow jar [spark-kubernetes-operator]

dongjoon-hyun opened a new pull request, #734:
URL: https://github.com/apache/spark-kubernetes-operator/pull/734

   ### What changes were proposed in this pull request?
   
   This PR excludes the Hadoop `filecache` package (`org/apache/hadoop/filecache/**`) from the
   operator shadow jar by adding a class-path filter to the `shadowJar` block in
   `spark-operator/build.gradle`.
   
   ### Why are the changes needed?
   
   The operator never uses Hadoop `DistributedCache`. While the `minimize` step already drops the
   unreferenced `DistributedCache` class, the package directory entry and `package-info.class`
   (from `hadoop-client-api`) still remain in the shadow jar. This change removes those leftover
   entries explicitly, consistent with the existing MapReduce exclusions.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Pass the CIs.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Fable 5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57875] Exclude Hadoop `filecache` classes from shadow jar [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #734: [SPARK-57875] Exclude Hadoop `filecache` classes from shadow jar
URL: https://github.com/apache/spark-kubernetes-operator/pull/734


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57875] Exclude Hadoop `filecache` classes from shadow jar [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #734:
URL: https://github.com/apache/spark-kubernetes-operator/pull/734#issuecomment-4862647243

   Thank you, @peter-toth and @viirya .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57875] Exclude Hadoop `filecache` classes from shadow jar [spark-kubernetes-operator]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #734:
URL: https://github.com/apache/spark-kubernetes-operator/pull/734#issuecomment-4862651084

   Merged to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org