[jira] [Commented] (SOLR-9117) Leaking the first SolrCore after reload

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337020#comment-15337020 ] 

ASF subversion and git services commented on SOLR-9117:
-------------------------------------------------------

Commit 1df6d4f078de33ac3f49dd33b09d3ae8c90f5137 in lucene-solr's branch refs/heads/branch_5x from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1df6d4f ]

SOLR-9117: The first SolrCore is leaked after reload
(cherry picked from commit d1202a8)


> Leaking the first SolrCore after reload
> ---------------------------------------
>
>                 Key: SOLR-9117
>                 URL: https://issues.apache.org/jira/browse/SOLR-9117
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Jessica Cheng Mallet
>            Assignee: Shalin Shekhar Mangar
>              Labels: core, leak
>             Fix For: 5.6, 6.0.1, 6.1, 5.5.2, master (7.0)
>
>         Attachments: SOLR-9117.patch
>
>
> When a SolrCore for a particular index is created for the first time, it's added to the SolrCores#createdCores map. However, this map doesn't get updated when this core is reloaded, leading to the first SolrCore being leaked.
> Taking a look at how createdCores is used, it seems like it doesn't serve any purpose (its only read is in SolrCores#getAllCoreNames, which includes entries from SolrCores.cores anyway), so I'm proposing a patch to remove the createdCores map completely. However, if someone else knows that createdCores exist for a reason, I'll be happy to change the fix to updating the createdCores map when reload is called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org