[PATCH] Deprecated function called in subversion/libsvn_wc/info.c svn_wc_info_dup

[Gabriela Gibson <ga...@gmail.com>]

[[[
Update call to deprecated function.

* subversion/libsvn_wc/info.c:
   (svn_wc_info_dup): Update call to deprecated function and type to
   current versions.

]]]
:

Re: [PATCH] Deprecated function called in subversion/libsvn_wc/info.c svn_wc_info_dup

[Ben Reser <be...@reser.org>]

On 8/21/13 10:02 AM, Gabriela Gibson wrote:
> [[[
> Update call to deprecated function.
> 
> * subversion/libsvn_wc/info.c:
>   (svn_wc_info_dup): Update call to deprecated function and type to
>   current versions.
> 
> ]]]
> :

Can't do that.  svn_wc_info_dup() duplicates a svn_wc_info_t struct in
which the conflicts member is described as an array of
svn_wc_conflict_description2_t pointers.  svn_wc_info_t needs to be
revved and then svn_wc_info_dup would be revved as well.

The only reason this doesn't blow up on you is that the array code
doesn't care what type of pointer it gets and svn_wc_info_dup() is only
used by svn_client_info2_dup() which we don't use in our code.

Re: [PATCH] Deprecated function called in subversion/libsvn_wc/info.c svn_wc_info_dup

[Branko Čibej <br...@wandisco.com>]

On 21.08.2013 19:02, Gabriela Gibson wrote:
> [[[
> Update call to deprecated function.
>
> * subversion/libsvn_wc/info.c:
>   (svn_wc_info_dup): Update call to deprecated function and type to
>   current versions.
>
> ]]]
> :

You can't just replace the function like that, the svn_wc_info_t does
not contain the newer conflict descriptor type structures.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com