[GitHub] [hadoop] aajisaka commented on a diff in pull request #4135: HADOOP-18188. Support touch command for directory

[GitBox <gi...@apache.org>]

aajisaka commented on code in PR #4135:
URL: https://github.com/apache/hadoop/pull/4135#discussion_r843470319


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShellTouch.java:
##########
@@ -200,6 +200,72 @@ public void testTouch() throws Exception {
     FileStatus fileStatus = lfs.getFileStatus(newFile);
     assertThat(fileStatus.getAccessTime()).isEqualTo(dateObj.getTime());
     assertThat(fileStatus.getModificationTime()).isEqualTo(dateObj.getTime());
+
+    touchDirTests();
+  }
+
+  private void touchDirTests() throws Exception {

Review Comment:
   How about creating a separate test method for directory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org