You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2016/07/26 10:05:56 UTC

Review Request 50440: Remove ranger_solrj module

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50440/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1122
    https://issues.apache.org/jira/browse/RANGER-1122


Repository: ranger


Description
-------

This task is to remove the ranger_solrj module. It's not used by any other ranger component or in any of the assembly files. It contains code that is available in Apache Solr anyway.


Diffs
-----

  pom.xml 0abb7f3 
  ranger_solrj/.gitignore b83d222 
  ranger_solrj/pom.xml 163d407 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/ResponseParser.java d5c3b38 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrClient.java 5c06a03 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrQuery.java bda6f34 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrRequest.java 6d4efb6 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrResponse.java 244a757 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrServer.java 0238214 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrServerException.java ed16a43 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/StreamingResponseCallback.java 2ba79c8 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/BindingException.java fc9ebfa 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java bff6c6a 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/Field.java 39f6752 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/package-info.java 890005f 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/BinaryRequestWriter.java 629c537 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/BinaryResponseParser.java 4f3caf1 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java 8508268 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/CloudSolrServer.java 4e2a2e7 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java 5e65021 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServer.java 9ace82a 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpClientConfigurer.java 78ed726 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java 96ed211 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java a073265 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java ef5d439 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java c524b1f 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/LBHttpSolrServer.java ee28241 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/NoOpResponseParser.java e9a346c 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/StreamingBinaryResponseParser.java 14be1f3 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java f9177c8 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/package-info.java 491ef05 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/package-info.java b88918e 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/AbstractUpdateRequest.java 0588fc1 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java 1ad0b26 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/ContentStreamUpdateRequest.java 44e37c9 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java b0c0409 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/DirectXmlRequest.java 1efaaf5 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/DocumentAnalysisRequest.java 92e2064 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/FieldAnalysisRequest.java 66ef535 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/IsUpdateRequest.java c1907d0 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java b46dc94 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/LukeRequest.java 82b5330 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/QueryRequest.java 9d47f99 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/RequestWriter.java 15872b2 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/SolrPing.java 00ad41f 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/UpdateRequest.java 0e6580c 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/package-info.java 899a562 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/AnalysisResponseBase.java 21396a5 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/CollectionAdminResponse.java 8acf2e2 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/CoreAdminResponse.java 0492165 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/DocumentAnalysisResponse.java 2f11d78 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/FacetField.java 086c999 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/FieldAnalysisResponse.java 9c542d7 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/FieldStatsInfo.java 9685832 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/Group.java bc4271a 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/GroupCommand.java 58bb9cb 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/GroupResponse.java 3549101 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/IntervalFacet.java b6ec6c3 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/LukeResponse.java 5d2f328 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/PivotField.java 3b084f6 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/QueryResponse.java 89cd971 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/RangeFacet.java fbb5c31 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/SolrPingResponse.java cbd892f 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/SolrResponseBase.java ca59e54 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/SpellCheckResponse.java 798c088 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/TermsResponse.java 29be7dd 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/UpdateResponse.java 7a62bc0 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/package-info.java e2bbe3a 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/util/ClientUtils.java f2e4036 
  ranger_solrj/src/main/java/org/apache/solr/client/solrj/util/package-info.java 9464970 
  ranger_solrj/src/main/java/org/apache/solr/common/EnumFieldValue.java 0e92a11 
  ranger_solrj/src/main/java/org/apache/solr/common/SolrDocument.java b7e4465 
  ranger_solrj/src/main/java/org/apache/solr/common/SolrDocumentList.java d803e7d 
  ranger_solrj/src/main/java/org/apache/solr/common/SolrException.java 3430ff8 
  ranger_solrj/src/main/java/org/apache/solr/common/SolrInputDocument.java a51efbf 
  ranger_solrj/src/main/java/org/apache/solr/common/SolrInputField.java 02b6856 
  ranger_solrj/src/main/java/org/apache/solr/common/StringUtils.java 4d2da92 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/Aliases.java d335f89 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/BeforeReconnect.java b904a46 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClosableThread.java f49b0ed 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClusterState.java 3a468ae 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClusterStateUtil.java 0cc98b1 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/CompositeIdRouter.java 668519c 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ConnectionManager.java 699f2ae 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/DefaultConnectionStrategy.java 80cc3b2 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/DefaultZkACLProvider.java e55ccf1 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/DefaultZkCredentialsProvider.java ce9ecc3 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/DocCollection.java f905df5 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/DocRouter.java e245005 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/HashBasedRouter.java d6e4319 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ImplicitDocRouter.java 859a045 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/OnReconnect.java 2e390a2 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/PlainIdRouter.java fb1210f 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/Replica.java bef338b 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/RoutingRule.java 915c71f 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/SaslZkACLProvider.java 54f2eee 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/Slice.java 6e0ca55 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/SolrZkClient.java 00da70b 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/SolrZooKeeper.java b83c692 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/VMParamsAllAndReadonlyDigestZkACLProvider.java 1c3c6ca 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/VMParamsSingleSetCredentialsDigestZkCredentialsProvider.java f71e2ec 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkACLProvider.java 7cff190 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkClientConnectionStrategy.java 54c0e25 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCmdExecutor.java c027cf2 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkConfigManager.java a3a8060 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCoreNodeProps.java 3031087 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCredentialsProvider.java 012bf5d 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkNodeProps.java 9adffd0 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkOperation.java 9ea283b 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkStateReader.java 457c7fa 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZooKeeperException.java 7c4761a 
  ranger_solrj/src/main/java/org/apache/solr/common/cloud/package-info.java 04ef67c 
  ranger_solrj/src/main/java/org/apache/solr/common/luke/FieldFlag.java 274e0b4 
  ranger_solrj/src/main/java/org/apache/solr/common/luke/package-info.java e710d39 
  ranger_solrj/src/main/java/org/apache/solr/common/package-info.java 690a83c 
  ranger_solrj/src/main/java/org/apache/solr/common/params/AnalysisParams.java 39fce0c 
  ranger_solrj/src/main/java/org/apache/solr/common/params/AppendedSolrParams.java 4c9cc2e 
  ranger_solrj/src/main/java/org/apache/solr/common/params/CollectionParams.java 51c3fc5 
  ranger_solrj/src/main/java/org/apache/solr/common/params/CommonParams.java 858500f 
  ranger_solrj/src/main/java/org/apache/solr/common/params/CoreAdminParams.java f673c6c 
  ranger_solrj/src/main/java/org/apache/solr/common/params/CursorMarkParams.java 8cd2a67 
  ranger_solrj/src/main/java/org/apache/solr/common/params/DefaultSolrParams.java 1f308cd 
  ranger_solrj/src/main/java/org/apache/solr/common/params/DisMaxParams.java 9a0abe6 
  ranger_solrj/src/main/java/org/apache/solr/common/params/EventParams.java e41911f 
  ranger_solrj/src/main/java/org/apache/solr/common/params/ExpandParams.java 5ea7d99 
  ranger_solrj/src/main/java/org/apache/solr/common/params/FacetParams.java 42bd1fc 
  ranger_solrj/src/main/java/org/apache/solr/common/params/GroupParams.java 36f11cf 
  ranger_solrj/src/main/java/org/apache/solr/common/params/HighlightParams.java 66c2542 
  ranger_solrj/src/main/java/org/apache/solr/common/params/MapSolrParams.java f2a1c37 
  ranger_solrj/src/main/java/org/apache/solr/common/params/ModifiableSolrParams.java b84f4aa 
  ranger_solrj/src/main/java/org/apache/solr/common/params/MoreLikeThisParams.java 44a950f 
  ranger_solrj/src/main/java/org/apache/solr/common/params/MultiMapSolrParams.java 684396b 
  ranger_solrj/src/main/java/org/apache/solr/common/params/QueryElevationParams.java 3271c38 
  ranger_solrj/src/main/java/org/apache/solr/common/params/RequiredSolrParams.java 0b78d41 
  ranger_solrj/src/main/java/org/apache/solr/common/params/ShardParams.java 70a39fd 
  ranger_solrj/src/main/java/org/apache/solr/common/params/SimpleParams.java 6788546 
  ranger_solrj/src/main/java/org/apache/solr/common/params/SolrParams.java 36d0df1 
  ranger_solrj/src/main/java/org/apache/solr/common/params/SpatialParams.java 39f3dbe 
  ranger_solrj/src/main/java/org/apache/solr/common/params/SpellingParams.java 0a54606 
  ranger_solrj/src/main/java/org/apache/solr/common/params/StatsParams.java d287fa3 
  ranger_solrj/src/main/java/org/apache/solr/common/params/TermVectorParams.java 438bf5e 
  ranger_solrj/src/main/java/org/apache/solr/common/params/TermsParams.java 63d1d28 
  ranger_solrj/src/main/java/org/apache/solr/common/params/UpdateParams.java 75f8857 
  ranger_solrj/src/main/java/org/apache/solr/common/params/package-info.java 94622cc 
  ranger_solrj/src/main/java/org/apache/solr/common/util/Base64.java 8cc3381 
  ranger_solrj/src/main/java/org/apache/solr/common/util/ByteUtils.java 9ce607e 
  ranger_solrj/src/main/java/org/apache/solr/common/util/ContentStream.java b455d80 
  ranger_solrj/src/main/java/org/apache/solr/common/util/ContentStreamBase.java 24549b6 
  ranger_solrj/src/main/java/org/apache/solr/common/util/DataInputInputStream.java d412f40 
  ranger_solrj/src/main/java/org/apache/solr/common/util/DateUtil.java 6409dbc 
  ranger_solrj/src/main/java/org/apache/solr/common/util/ExecutorUtil.java f17316c 
  ranger_solrj/src/main/java/org/apache/solr/common/util/FastInputStream.java 8a2ecee 
  ranger_solrj/src/main/java/org/apache/solr/common/util/FastOutputStream.java 09a7441 
  ranger_solrj/src/main/java/org/apache/solr/common/util/Hash.java f541fe1 
  ranger_solrj/src/main/java/org/apache/solr/common/util/IOUtils.java c9d7274 
  ranger_solrj/src/main/java/org/apache/solr/common/util/IteratorChain.java 8a0bb1d 
  ranger_solrj/src/main/java/org/apache/solr/common/util/JavaBinCodec.java 687525c 
  ranger_solrj/src/main/java/org/apache/solr/common/util/JsonRecordReader.java c3afde7 
  ranger_solrj/src/main/java/org/apache/solr/common/util/NamedList.java c539b2b 
  ranger_solrj/src/main/java/org/apache/solr/common/util/ObjectReleaseTracker.java 8be12df 
  ranger_solrj/src/main/java/org/apache/solr/common/util/RetryUtil.java e3a0c5b 
  ranger_solrj/src/main/java/org/apache/solr/common/util/SimpleOrderedMap.java 1a217e7 
  ranger_solrj/src/main/java/org/apache/solr/common/util/SolrjNamedThreadFactory.java 46e462d 
  ranger_solrj/src/main/java/org/apache/solr/common/util/StrUtils.java 8ac87d7 
  ranger_solrj/src/main/java/org/apache/solr/common/util/URLUtil.java 6d273ec 
  ranger_solrj/src/main/java/org/apache/solr/common/util/XML.java 50a6da2 
  ranger_solrj/src/main/java/org/apache/solr/common/util/XMLErrorLogger.java 7f45ff9 
  ranger_solrj/src/main/java/org/apache/solr/common/util/package-info.java 1da825f 
  ranger_solrj/src/main/java/overview.html 7a534ed 

Diff: https://reviews.apache.org/r/50440/diff/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 50440: Remove ranger_solrj module

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50440/#review143550
-----------------------------------------------------------


Ship it!




Ship It!

- Don Bosco Durai


On July 26, 2016, 10:05 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50440/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 10:05 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1122
>     https://issues.apache.org/jira/browse/RANGER-1122
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> This task is to remove the ranger_solrj module. It's not used by any other ranger component or in any of the assembly files. It contains code that is available in Apache Solr anyway.
> 
> 
> Diffs
> -----
> 
>   pom.xml 0abb7f3 
>   ranger_solrj/.gitignore b83d222 
>   ranger_solrj/pom.xml 163d407 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/ResponseParser.java d5c3b38 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrClient.java 5c06a03 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrQuery.java bda6f34 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrRequest.java 6d4efb6 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrResponse.java 244a757 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrServer.java 0238214 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/SolrServerException.java ed16a43 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/StreamingResponseCallback.java 2ba79c8 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/BindingException.java fc9ebfa 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/DocumentObjectBinder.java bff6c6a 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/Field.java 39f6752 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/beans/package-info.java 890005f 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/BinaryRequestWriter.java 629c537 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/BinaryResponseParser.java 4f3caf1 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java 8508268 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/CloudSolrServer.java 4e2a2e7 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java 5e65021 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrServer.java 9ace82a 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpClientConfigurer.java 78ed726 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java 96ed211 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java a073265 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java ef5d439 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java c524b1f 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/LBHttpSolrServer.java ee28241 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/NoOpResponseParser.java e9a346c 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/StreamingBinaryResponseParser.java 14be1f3 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/XMLResponseParser.java f9177c8 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/impl/package-info.java 491ef05 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/package-info.java b88918e 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/AbstractUpdateRequest.java 0588fc1 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java 1ad0b26 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/ContentStreamUpdateRequest.java 44e37c9 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/CoreAdminRequest.java b0c0409 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/DirectXmlRequest.java 1efaaf5 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/DocumentAnalysisRequest.java 92e2064 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/FieldAnalysisRequest.java 66ef535 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/IsUpdateRequest.java c1907d0 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/JavaBinUpdateRequestCodec.java b46dc94 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/LukeRequest.java 82b5330 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/QueryRequest.java 9d47f99 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/RequestWriter.java 15872b2 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/SolrPing.java 00ad41f 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/UpdateRequest.java 0e6580c 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/request/package-info.java 899a562 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/AnalysisResponseBase.java 21396a5 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/CollectionAdminResponse.java 8acf2e2 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/CoreAdminResponse.java 0492165 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/DocumentAnalysisResponse.java 2f11d78 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/FacetField.java 086c999 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/FieldAnalysisResponse.java 9c542d7 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/FieldStatsInfo.java 9685832 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/Group.java bc4271a 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/GroupCommand.java 58bb9cb 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/GroupResponse.java 3549101 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/IntervalFacet.java b6ec6c3 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/LukeResponse.java 5d2f328 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/PivotField.java 3b084f6 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/QueryResponse.java 89cd971 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/RangeFacet.java fbb5c31 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/SolrPingResponse.java cbd892f 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/SolrResponseBase.java ca59e54 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/SpellCheckResponse.java 798c088 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/TermsResponse.java 29be7dd 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/UpdateResponse.java 7a62bc0 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/response/package-info.java e2bbe3a 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/util/ClientUtils.java f2e4036 
>   ranger_solrj/src/main/java/org/apache/solr/client/solrj/util/package-info.java 9464970 
>   ranger_solrj/src/main/java/org/apache/solr/common/EnumFieldValue.java 0e92a11 
>   ranger_solrj/src/main/java/org/apache/solr/common/SolrDocument.java b7e4465 
>   ranger_solrj/src/main/java/org/apache/solr/common/SolrDocumentList.java d803e7d 
>   ranger_solrj/src/main/java/org/apache/solr/common/SolrException.java 3430ff8 
>   ranger_solrj/src/main/java/org/apache/solr/common/SolrInputDocument.java a51efbf 
>   ranger_solrj/src/main/java/org/apache/solr/common/SolrInputField.java 02b6856 
>   ranger_solrj/src/main/java/org/apache/solr/common/StringUtils.java 4d2da92 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/Aliases.java d335f89 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/BeforeReconnect.java b904a46 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClosableThread.java f49b0ed 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClusterState.java 3a468ae 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ClusterStateUtil.java 0cc98b1 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/CompositeIdRouter.java 668519c 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ConnectionManager.java 699f2ae 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/DefaultConnectionStrategy.java 80cc3b2 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/DefaultZkACLProvider.java e55ccf1 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/DefaultZkCredentialsProvider.java ce9ecc3 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/DocCollection.java f905df5 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/DocRouter.java e245005 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/HashBasedRouter.java d6e4319 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ImplicitDocRouter.java 859a045 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/OnReconnect.java 2e390a2 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/PlainIdRouter.java fb1210f 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/Replica.java bef338b 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/RoutingRule.java 915c71f 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/SaslZkACLProvider.java 54f2eee 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/Slice.java 6e0ca55 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/SolrZkClient.java 00da70b 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/SolrZooKeeper.java b83c692 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/VMParamsAllAndReadonlyDigestZkACLProvider.java 1c3c6ca 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/VMParamsSingleSetCredentialsDigestZkCredentialsProvider.java f71e2ec 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkACLProvider.java 7cff190 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkClientConnectionStrategy.java 54c0e25 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCmdExecutor.java c027cf2 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkConfigManager.java a3a8060 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCoreNodeProps.java 3031087 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkCredentialsProvider.java 012bf5d 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkNodeProps.java 9adffd0 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkOperation.java 9ea283b 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZkStateReader.java 457c7fa 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/ZooKeeperException.java 7c4761a 
>   ranger_solrj/src/main/java/org/apache/solr/common/cloud/package-info.java 04ef67c 
>   ranger_solrj/src/main/java/org/apache/solr/common/luke/FieldFlag.java 274e0b4 
>   ranger_solrj/src/main/java/org/apache/solr/common/luke/package-info.java e710d39 
>   ranger_solrj/src/main/java/org/apache/solr/common/package-info.java 690a83c 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/AnalysisParams.java 39fce0c 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/AppendedSolrParams.java 4c9cc2e 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/CollectionParams.java 51c3fc5 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/CommonParams.java 858500f 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/CoreAdminParams.java f673c6c 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/CursorMarkParams.java 8cd2a67 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/DefaultSolrParams.java 1f308cd 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/DisMaxParams.java 9a0abe6 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/EventParams.java e41911f 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/ExpandParams.java 5ea7d99 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/FacetParams.java 42bd1fc 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/GroupParams.java 36f11cf 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/HighlightParams.java 66c2542 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/MapSolrParams.java f2a1c37 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/ModifiableSolrParams.java b84f4aa 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/MoreLikeThisParams.java 44a950f 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/MultiMapSolrParams.java 684396b 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/QueryElevationParams.java 3271c38 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/RequiredSolrParams.java 0b78d41 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/ShardParams.java 70a39fd 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/SimpleParams.java 6788546 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/SolrParams.java 36d0df1 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/SpatialParams.java 39f3dbe 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/SpellingParams.java 0a54606 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/StatsParams.java d287fa3 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/TermVectorParams.java 438bf5e 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/TermsParams.java 63d1d28 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/UpdateParams.java 75f8857 
>   ranger_solrj/src/main/java/org/apache/solr/common/params/package-info.java 94622cc 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/Base64.java 8cc3381 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/ByteUtils.java 9ce607e 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/ContentStream.java b455d80 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/ContentStreamBase.java 24549b6 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/DataInputInputStream.java d412f40 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/DateUtil.java 6409dbc 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/ExecutorUtil.java f17316c 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/FastInputStream.java 8a2ecee 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/FastOutputStream.java 09a7441 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/Hash.java f541fe1 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/IOUtils.java c9d7274 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/IteratorChain.java 8a0bb1d 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/JavaBinCodec.java 687525c 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/JsonRecordReader.java c3afde7 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/NamedList.java c539b2b 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/ObjectReleaseTracker.java 8be12df 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/RetryUtil.java e3a0c5b 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/SimpleOrderedMap.java 1a217e7 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/SolrjNamedThreadFactory.java 46e462d 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/StrUtils.java 8ac87d7 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/URLUtil.java 6d273ec 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/XML.java 50a6da2 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/XMLErrorLogger.java 7f45ff9 
>   ranger_solrj/src/main/java/org/apache/solr/common/util/package-info.java 1da825f 
>   ranger_solrj/src/main/java/overview.html 7a534ed 
> 
> Diff: https://reviews.apache.org/r/50440/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>