You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by lion-x <gi...@git.apache.org> on 2016/10/14 03:31:45 UTC
[GitHub] incubator-carbondata pull request #238: [WIP] Correct Some Spelling Mistakes
GitHub user lion-x opened a pull request:
https://github.com/apache/incubator-carbondata/pull/238
[WIP] Correct Some Spelling Mistakes
# Why raise this PR?
Correct some simple spelling mistakes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lion-x/incubator-carbondata SpellingMistakes1014
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/238.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #238
----
commit 20808c64525a7641785ae000c6f1e1e986c4dc4c
Author: lion-x <xl...@gmail.com>
Date: 2016-10-14T03:26:33Z
Correct Some Spelling mistakes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #238: [CARBONDATA-334] Correct Some Spelli...
Posted by lion-x <gi...@git.apache.org>.
Github user lion-x commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/238#discussion_r84610187
--- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java ---
@@ -346,26 +346,26 @@ public static void executeGraph(LoadModel loadModel, String storeLocation, Strin
path.delete();
}
- DataProcessTaskStatus schmaModel = new DataProcessTaskStatus(databaseName, tableName);
- schmaModel.setCsvFilePath(loadModel.getFactFilePath());
+ DataProcessTaskStatus schemaModel = new DataProcessTaskStatus(databaseName, tableName);
--- End diff --
revised the value name by your comment, pls check.
CI pass, Update.
http://136.243.101.176:8080/job/ApacheCarbonManualPRBuilder/471/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #238: [CARBONDATA-334] Correct Some Spelli...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/238#discussion_r84463724
--- Diff: hadoop/src/test/java/org/apache/carbondata/hadoop/test/util/StoreCreator.java ---
@@ -346,26 +346,26 @@ public static void executeGraph(LoadModel loadModel, String storeLocation, Strin
path.delete();
}
- DataProcessTaskStatus schmaModel = new DataProcessTaskStatus(databaseName, tableName);
- schmaModel.setCsvFilePath(loadModel.getFactFilePath());
+ DataProcessTaskStatus schemaModel = new DataProcessTaskStatus(databaseName, tableName);
--- End diff --
This is not schemaModel, please use a proper name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #238: [CARBONDATA-334] Correct Some Spelli...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---