You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by Antoine Toulme <an...@toulme.name> on 2019/12/01 01:47:02 UTC
[VOTE] Tuweni 0.10.0-incubating release
We're voting on the distributions available here:
https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
The release tag is present here:
https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
This release includes the following changes:
• Added discv5
• Bytes fixes and enhancements
• Fixes and minor enhancements to UInt256
Here’s my +1.
Cheers,
Antoine
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
Nit is fixed and KEYS file is now here:
https://dist.apache.org/repos/dist/dev/incubator/tuweni/KEYS <https://dist.apache.org/repos/dist/dev/incubator/tuweni/KEYS>
Cheers,
Antoine
> On Dec 6, 2019, at 1:16 AM, Jim Jagielski <ji...@jaguNET.com> wrote:
>
> +1 (w/ the fixed nit)
>
>> On Dec 4, 2019, at 12:16 PM, Antoine Toulme <an...@toulme.name> wrote:
>>
>> Will fix the nit. If one more mentor can vote this release, that’d be swell :)
>>
>>> On Dec 4, 2019, at 08:19, larry mccay <lm...@apache.org> wrote:
>>>
>>> Thank you for this release candidate and VOTE, Antoine!
>>>
>>> I have:
>>>
>>> * built from source and run the unit tests
>>> * reviewed LICENSE, NOTICE and DISCLAIMER files
>>> * verified signatures
>>>
>>> nit: KEYS file should have a link in the VOTE email and should actually be
>>> colocated with the rc in a parent directory.
>>>
>>> +1
>>>
>>>
>>>> On Tue, Dec 3, 2019 at 6:58 PM Antoine Toulme <an...@toulme.name> wrote:
>>>>
>>>> Thanks Furkan.
>>>>
>>>> The release vote has stalled. I’ll call it tomorrow unless more votes come
>>>> in.
>>>>
>>>> Cheers!
>>>>
>>>> Antoine
>>>>
>>>>> On Dec 2, 2019, at 12:08 PM, Furkan KAMACI <fu...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi Antoine,
>>>>>
>>>>> Thanks! Yes, it's been pointed at there, OK.
>>>>>
>>>>> Kind Regards,
>>>>> Furkan KAMACI
>>>>>
>>>>> On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name>
>>>> wrote:
>>>>>
>>>>>> I wrote ProgPoW by myself, following the specification and seminal work
>>>> by
>>>>>> Danno Ferrin.
>>>>>>
>>>>>> It’s under ASF copyright fair and square.
>>>>>>
>>>>>> The algorithm of ProgPoW is licensed under CCO, which was the cause of
>>>>>> concern as their reference implementation is non-ASL compatible.
>>>>>>
>>>>>> I therefore added a comment in the class explaining the provenance of
>>>> the
>>>>>> algorithm:
>>>>>>
>>>>>>
>>>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>>> <
>>>>>>
>>>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>>>>
>>>>>>
>>>>>> You voted on those changes in release 0.8.2:
>>>>>>
>>>>>>
>>>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>>> <
>>>>>>
>>>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>>>>
>>>>>>
>>>>>> Please let me know if I need to do anything else.
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Antoine
>>>>>>
>>>>>>> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi Antoine,
>>>>>>>
>>>>>>> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>>>>>>>
>>>>>>> Kind Regards,
>>>>>>> Furkan KAMACI
>>>>>>>
>>>>>>> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
>>>>>> wrote:
>>>>>>>
>>>>>>>> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
>>>>>> 0.8.1,
>>>>>>>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>>>>>>>
>>>>>>>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> +1 from me.
>>>>>>>>>
>>>>>>>>> I checked:
>>>>>>>>>
>>>>>>>>> - Incubating in name
>>>>>>>>> - DISCLAIMER exists
>>>>>>>>> - LICENSE and NOTICE are fine
>>>>>>>>> - No unexpected binary files
>>>>>>>>> - Checked PGP signatures
>>>>>>>>> - Checked Checksums
>>>>>>>>> - Code compiles and tests successfully run
>>>>>>>>>
>>>>>>>>> Comments:
>>>>>>>>>
>>>>>>>>> 1) You should fix build instructions to include minimum required
>>>> Java 8
>>>>>>>>> minor version.
>>>>>>>>> 2) Tidy up indentation of DISCLAIMER. See
>>>>>>>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>>>>>>>>> 3) Please be sure that "all" steps are OK at here:
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>>>>>>>>>
>>>>>>>>> Kind Regards,
>>>>>>>>> Furkan KAMACI
>>>>>>>>>
>>>>>>>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> You’re using a very old version of JDK8, and the later versions
>>>> behave
>>>>>>>>>> differently.
>>>>>>>>>>
>>>>>>>>>> This tells me we need to move to Java 11.
>>>>>>>>>>
>>>>>>>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I still get the same error as previous version:
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>>>>>>>>>
>>>>>>>>>>> Kind Regards,
>>>>>>>>>>> Furkan KAMACI
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jonathan.rhea@gmail.com
>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> looks good
>>>>>>>>>>>> +1
>>>>>>>>>>>>
>>>>>>>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <antoine@toulme.name
>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> We're voting on the distributions available here:
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>>>>>>>>>> The release tag is present here:
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>>>>>>>>>
>>>>>>>>>>>>> This release includes the following changes:
>>>>>>>>>>>>> • Added discv5
>>>>>>>>>>>>> • Bytes fixes and enhancements
>>>>>>>>>>>>> • Fixes and minor enhancements to UInt256
>>>>>>>>>>>>>
>>>>>>>>>>>>> Here’s my +1.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Cheers,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Antoine
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
[RESULT][VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
Thanks all for your participation.
Here are the votes:
6 +1s:
Jim Jagielski (IPMC)
Furkan Kamaci (IPMC)
Larry McCay (IPMC)
Mikhail Kalinin
Jonny Rhea
Antoine Toulme
0 +0s
0 -1s
The vote passes successfully. I will open a new thread with the general incubator list.
Cheers,
Antoine
> On Dec 6, 2019, at 1:16 AM, Jim Jagielski <ji...@jaguNET.com> wrote:
>
> +1 (w/ the fixed nit)
>
>> On Dec 4, 2019, at 12:16 PM, Antoine Toulme <an...@toulme.name> wrote:
>>
>> Will fix the nit. If one more mentor can vote this release, that’d be swell :)
>>
>>> On Dec 4, 2019, at 08:19, larry mccay <lm...@apache.org> wrote:
>>>
>>> Thank you for this release candidate and VOTE, Antoine!
>>>
>>> I have:
>>>
>>> * built from source and run the unit tests
>>> * reviewed LICENSE, NOTICE and DISCLAIMER files
>>> * verified signatures
>>>
>>> nit: KEYS file should have a link in the VOTE email and should actually be
>>> colocated with the rc in a parent directory.
>>>
>>> +1
>>>
>>>
>>>> On Tue, Dec 3, 2019 at 6:58 PM Antoine Toulme <an...@toulme.name> wrote:
>>>>
>>>> Thanks Furkan.
>>>>
>>>> The release vote has stalled. I’ll call it tomorrow unless more votes come
>>>> in.
>>>>
>>>> Cheers!
>>>>
>>>> Antoine
>>>>
>>>>> On Dec 2, 2019, at 12:08 PM, Furkan KAMACI <fu...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi Antoine,
>>>>>
>>>>> Thanks! Yes, it's been pointed at there, OK.
>>>>>
>>>>> Kind Regards,
>>>>> Furkan KAMACI
>>>>>
>>>>> On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name>
>>>> wrote:
>>>>>
>>>>>> I wrote ProgPoW by myself, following the specification and seminal work
>>>> by
>>>>>> Danno Ferrin.
>>>>>>
>>>>>> It’s under ASF copyright fair and square.
>>>>>>
>>>>>> The algorithm of ProgPoW is licensed under CCO, which was the cause of
>>>>>> concern as their reference implementation is non-ASL compatible.
>>>>>>
>>>>>> I therefore added a comment in the class explaining the provenance of
>>>> the
>>>>>> algorithm:
>>>>>>
>>>>>>
>>>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>>> <
>>>>>>
>>>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>>>>
>>>>>>
>>>>>> You voted on those changes in release 0.8.2:
>>>>>>
>>>>>>
>>>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>>> <
>>>>>>
>>>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>>>>
>>>>>>
>>>>>> Please let me know if I need to do anything else.
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Antoine
>>>>>>
>>>>>>> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi Antoine,
>>>>>>>
>>>>>>> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>>>>>>>
>>>>>>> Kind Regards,
>>>>>>> Furkan KAMACI
>>>>>>>
>>>>>>> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
>>>>>> wrote:
>>>>>>>
>>>>>>>> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
>>>>>> 0.8.1,
>>>>>>>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>>>>>>>
>>>>>>>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> +1 from me.
>>>>>>>>>
>>>>>>>>> I checked:
>>>>>>>>>
>>>>>>>>> - Incubating in name
>>>>>>>>> - DISCLAIMER exists
>>>>>>>>> - LICENSE and NOTICE are fine
>>>>>>>>> - No unexpected binary files
>>>>>>>>> - Checked PGP signatures
>>>>>>>>> - Checked Checksums
>>>>>>>>> - Code compiles and tests successfully run
>>>>>>>>>
>>>>>>>>> Comments:
>>>>>>>>>
>>>>>>>>> 1) You should fix build instructions to include minimum required
>>>> Java 8
>>>>>>>>> minor version.
>>>>>>>>> 2) Tidy up indentation of DISCLAIMER. See
>>>>>>>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>>>>>>>>> 3) Please be sure that "all" steps are OK at here:
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>>>>>>>>>
>>>>>>>>> Kind Regards,
>>>>>>>>> Furkan KAMACI
>>>>>>>>>
>>>>>>>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> You’re using a very old version of JDK8, and the later versions
>>>> behave
>>>>>>>>>> differently.
>>>>>>>>>>
>>>>>>>>>> This tells me we need to move to Java 11.
>>>>>>>>>>
>>>>>>>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I still get the same error as previous version:
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>>>>>>>>>
>>>>>>>>>>> Kind Regards,
>>>>>>>>>>> Furkan KAMACI
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jonathan.rhea@gmail.com
>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> looks good
>>>>>>>>>>>> +1
>>>>>>>>>>>>
>>>>>>>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <antoine@toulme.name
>>>>>
>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> We're voting on the distributions available here:
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>>>>>>>>>> The release tag is present here:
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>>>>>>>>>
>>>>>>>>>>>>> This release includes the following changes:
>>>>>>>>>>>>> • Added discv5
>>>>>>>>>>>>> • Bytes fixes and enhancements
>>>>>>>>>>>>> • Fixes and minor enhancements to UInt256
>>>>>>>>>>>>>
>>>>>>>>>>>>> Here’s my +1.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Cheers,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Antoine
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1 (w/ the fixed nit)
> On Dec 4, 2019, at 12:16 PM, Antoine Toulme <an...@toulme.name> wrote:
>
> Will fix the nit. If one more mentor can vote this release, that’d be swell :)
>
>> On Dec 4, 2019, at 08:19, larry mccay <lm...@apache.org> wrote:
>>
>> Thank you for this release candidate and VOTE, Antoine!
>>
>> I have:
>>
>> * built from source and run the unit tests
>> * reviewed LICENSE, NOTICE and DISCLAIMER files
>> * verified signatures
>>
>> nit: KEYS file should have a link in the VOTE email and should actually be
>> colocated with the rc in a parent directory.
>>
>> +1
>>
>>
>>> On Tue, Dec 3, 2019 at 6:58 PM Antoine Toulme <an...@toulme.name> wrote:
>>>
>>> Thanks Furkan.
>>>
>>> The release vote has stalled. I’ll call it tomorrow unless more votes come
>>> in.
>>>
>>> Cheers!
>>>
>>> Antoine
>>>
>>>> On Dec 2, 2019, at 12:08 PM, Furkan KAMACI <fu...@gmail.com>
>>> wrote:
>>>>
>>>> Hi Antoine,
>>>>
>>>> Thanks! Yes, it's been pointed at there, OK.
>>>>
>>>> Kind Regards,
>>>> Furkan KAMACI
>>>>
>>>> On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name>
>>> wrote:
>>>>
>>>>> I wrote ProgPoW by myself, following the specification and seminal work
>>> by
>>>>> Danno Ferrin.
>>>>>
>>>>> It’s under ASF copyright fair and square.
>>>>>
>>>>> The algorithm of ProgPoW is licensed under CCO, which was the cause of
>>>>> concern as their reference implementation is non-ASL compatible.
>>>>>
>>>>> I therefore added a comment in the class explaining the provenance of
>>> the
>>>>> algorithm:
>>>>>
>>>>>
>>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>> <
>>>>>
>>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>>>
>>>>>
>>>>> You voted on those changes in release 0.8.2:
>>>>>
>>>>>
>>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>> <
>>>>>
>>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>>>
>>>>>
>>>>> Please let me know if I need to do anything else.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Antoine
>>>>>
>>>>>> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
>>>>> wrote:
>>>>>>
>>>>>> Hi Antoine,
>>>>>>
>>>>>> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>>>>>>
>>>>>> Kind Regards,
>>>>>> Furkan KAMACI
>>>>>>
>>>>>> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
>>>>> wrote:
>>>>>>
>>>>>>> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
>>>>> 0.8.1,
>>>>>>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>>>>>>
>>>>>>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> +1 from me.
>>>>>>>>
>>>>>>>> I checked:
>>>>>>>>
>>>>>>>> - Incubating in name
>>>>>>>> - DISCLAIMER exists
>>>>>>>> - LICENSE and NOTICE are fine
>>>>>>>> - No unexpected binary files
>>>>>>>> - Checked PGP signatures
>>>>>>>> - Checked Checksums
>>>>>>>> - Code compiles and tests successfully run
>>>>>>>>
>>>>>>>> Comments:
>>>>>>>>
>>>>>>>> 1) You should fix build instructions to include minimum required
>>> Java 8
>>>>>>>> minor version.
>>>>>>>> 2) Tidy up indentation of DISCLAIMER. See
>>>>>>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>>>>>>>> 3) Please be sure that "all" steps are OK at here:
>>>>>>>>
>>>>>>>
>>>>>
>>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>>>>>>>>
>>>>>>>> Kind Regards,
>>>>>>>> Furkan KAMACI
>>>>>>>>
>>>>>>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> You’re using a very old version of JDK8, and the later versions
>>> behave
>>>>>>>>> differently.
>>>>>>>>>
>>>>>>>>> This tells me we need to move to Java 11.
>>>>>>>>>
>>>>>>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I still get the same error as previous version:
>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>
>>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>>>>>>>>
>>>>>>>>>> Kind Regards,
>>>>>>>>>> Furkan KAMACI
>>>>>>>>>>
>>>>>>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jonathan.rhea@gmail.com
>>>>
>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> looks good
>>>>>>>>>>> +1
>>>>>>>>>>>
>>>>>>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <antoine@toulme.name
>>>>
>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> We're voting on the distributions available here:
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>
>>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>>>>>>>>> The release tag is present here:
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>
>>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>>>>>>>>
>>>>>>>>>>>> This release includes the following changes:
>>>>>>>>>>>> • Added discv5
>>>>>>>>>>>> • Bytes fixes and enhancements
>>>>>>>>>>>> • Fixes and minor enhancements to UInt256
>>>>>>>>>>>>
>>>>>>>>>>>> Here’s my +1.
>>>>>>>>>>>>
>>>>>>>>>>>> Cheers,
>>>>>>>>>>>>
>>>>>>>>>>>> Antoine
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>
>>>>>>>
>>>>>
>>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>
>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
Will fix the nit. If one more mentor can vote this release, that’d be swell :)
> On Dec 4, 2019, at 08:19, larry mccay <lm...@apache.org> wrote:
>
> Thank you for this release candidate and VOTE, Antoine!
>
> I have:
>
> * built from source and run the unit tests
> * reviewed LICENSE, NOTICE and DISCLAIMER files
> * verified signatures
>
> nit: KEYS file should have a link in the VOTE email and should actually be
> colocated with the rc in a parent directory.
>
> +1
>
>
>> On Tue, Dec 3, 2019 at 6:58 PM Antoine Toulme <an...@toulme.name> wrote:
>>
>> Thanks Furkan.
>>
>> The release vote has stalled. I’ll call it tomorrow unless more votes come
>> in.
>>
>> Cheers!
>>
>> Antoine
>>
>>> On Dec 2, 2019, at 12:08 PM, Furkan KAMACI <fu...@gmail.com>
>> wrote:
>>>
>>> Hi Antoine,
>>>
>>> Thanks! Yes, it's been pointed at there, OK.
>>>
>>> Kind Regards,
>>> Furkan KAMACI
>>>
>>> On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name>
>> wrote:
>>>
>>>> I wrote ProgPoW by myself, following the specification and seminal work
>> by
>>>> Danno Ferrin.
>>>>
>>>> It’s under ASF copyright fair and square.
>>>>
>>>> The algorithm of ProgPoW is licensed under CCO, which was the cause of
>>>> concern as their reference implementation is non-ASL compatible.
>>>>
>>>> I therefore added a comment in the class explaining the provenance of
>> the
>>>> algorithm:
>>>>
>>>>
>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>> <
>>>>
>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>>>
>>>>
>>>> You voted on those changes in release 0.8.2:
>>>>
>>>>
>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>> <
>>>>
>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>>>
>>>>
>>>> Please let me know if I need to do anything else.
>>>>
>>>> Cheers,
>>>>
>>>> Antoine
>>>>
>>>>> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi Antoine,
>>>>>
>>>>> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>>>>>
>>>>> Kind Regards,
>>>>> Furkan KAMACI
>>>>>
>>>>> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
>>>> wrote:
>>>>>
>>>>>> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
>>>> 0.8.1,
>>>>>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>>>>>
>>>>>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> +1 from me.
>>>>>>>
>>>>>>> I checked:
>>>>>>>
>>>>>>> - Incubating in name
>>>>>>> - DISCLAIMER exists
>>>>>>> - LICENSE and NOTICE are fine
>>>>>>> - No unexpected binary files
>>>>>>> - Checked PGP signatures
>>>>>>> - Checked Checksums
>>>>>>> - Code compiles and tests successfully run
>>>>>>>
>>>>>>> Comments:
>>>>>>>
>>>>>>> 1) You should fix build instructions to include minimum required
>> Java 8
>>>>>>> minor version.
>>>>>>> 2) Tidy up indentation of DISCLAIMER. See
>>>>>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>>>>>>> 3) Please be sure that "all" steps are OK at here:
>>>>>>>
>>>>>>
>>>>
>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>>>>>>>
>>>>>>> Kind Regards,
>>>>>>> Furkan KAMACI
>>>>>>>
>>>>>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>>>>>> wrote:
>>>>>>>
>>>>>>>> You’re using a very old version of JDK8, and the later versions
>> behave
>>>>>>>> differently.
>>>>>>>>
>>>>>>>> This tells me we need to move to Java 11.
>>>>>>>>
>>>>>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I still get the same error as previous version:
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>>>>>>>
>>>>>>>>> Kind Regards,
>>>>>>>>> Furkan KAMACI
>>>>>>>>>
>>>>>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jonathan.rhea@gmail.com
>>>
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> looks good
>>>>>>>>>> +1
>>>>>>>>>>
>>>>>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <antoine@toulme.name
>>>
>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> We're voting on the distributions available here:
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>>>>>>>> The release tag is present here:
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>>>>>>>
>>>>>>>>>>> This release includes the following changes:
>>>>>>>>>>> • Added discv5
>>>>>>>>>>> • Bytes fixes and enhancements
>>>>>>>>>>> • Fixes and minor enhancements to UInt256
>>>>>>>>>>>
>>>>>>>>>>> Here’s my +1.
>>>>>>>>>>>
>>>>>>>>>>> Cheers,
>>>>>>>>>>>
>>>>>>>>>>> Antoine
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>> ---------------------------------------------------------------------
>>>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>
>>>>>>
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by larry mccay <lm...@apache.org>.
Thank you for this release candidate and VOTE, Antoine!
I have:
* built from source and run the unit tests
* reviewed LICENSE, NOTICE and DISCLAIMER files
* verified signatures
nit: KEYS file should have a link in the VOTE email and should actually be
colocated with the rc in a parent directory.
+1
On Tue, Dec 3, 2019 at 6:58 PM Antoine Toulme <an...@toulme.name> wrote:
> Thanks Furkan.
>
> The release vote has stalled. I’ll call it tomorrow unless more votes come
> in.
>
> Cheers!
>
> Antoine
>
> > On Dec 2, 2019, at 12:08 PM, Furkan KAMACI <fu...@gmail.com>
> wrote:
> >
> > Hi Antoine,
> >
> > Thanks! Yes, it's been pointed at there, OK.
> >
> > Kind Regards,
> > Furkan KAMACI
> >
> > On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name>
> wrote:
> >
> >> I wrote ProgPoW by myself, following the specification and seminal work
> by
> >> Danno Ferrin.
> >>
> >> It’s under ASF copyright fair and square.
> >>
> >> The algorithm of ProgPoW is licensed under CCO, which was the cause of
> >> concern as their reference implementation is non-ASL compatible.
> >>
> >> I therefore added a comment in the class explaining the provenance of
> the
> >> algorithm:
> >>
> >>
> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
> >> <
> >>
> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
> >>>
> >>
> >> You voted on those changes in release 0.8.2:
> >>
> >>
> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
> >> <
> >>
> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
> >>>
> >>
> >> Please let me know if I need to do anything else.
> >>
> >> Cheers,
> >>
> >> Antoine
> >>
> >>> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
> >> wrote:
> >>>
> >>> Hi Antoine,
> >>>
> >>> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
> >>>
> >>> Kind Regards,
> >>> Furkan KAMACI
> >>>
> >>> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
> >> wrote:
> >>>
> >>>> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
> >> 0.8.1,
> >>>> 0.8.2. We went all over this. Which one do you see is not compliant?
> >>>>
> >>>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
> >>>> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> +1 from me.
> >>>>>
> >>>>> I checked:
> >>>>>
> >>>>> - Incubating in name
> >>>>> - DISCLAIMER exists
> >>>>> - LICENSE and NOTICE are fine
> >>>>> - No unexpected binary files
> >>>>> - Checked PGP signatures
> >>>>> - Checked Checksums
> >>>>> - Code compiles and tests successfully run
> >>>>>
> >>>>> Comments:
> >>>>>
> >>>>> 1) You should fix build instructions to include minimum required
> Java 8
> >>>>> minor version.
> >>>>> 2) Tidy up indentation of DISCLAIMER. See
> >>>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
> >>>>> 3) Please be sure that "all" steps are OK at here:
> >>>>>
> >>>>
> >>
> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
> >>>>>
> >>>>> Kind Regards,
> >>>>> Furkan KAMACI
> >>>>>
> >>>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
> >>>> wrote:
> >>>>>
> >>>>>> You’re using a very old version of JDK8, and the later versions
> behave
> >>>>>> differently.
> >>>>>>
> >>>>>> This tells me we need to move to Java 11.
> >>>>>>
> >>>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> I still get the same error as previous version:
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
> >>>>>>>
> >>>>>>> Kind Regards,
> >>>>>>> Furkan KAMACI
> >>>>>>>
> >>>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jonathan.rhea@gmail.com
> >
> >>>>>> wrote:
> >>>>>>>
> >>>>>>>> looks good
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <antoine@toulme.name
> >
> >>>>>> wrote:
> >>>>>>>>
> >>>>>>>>> We're voting on the distributions available here:
> >>>>>>>>>
> >>>>>>>>
> >>>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> >>>>>>>>> The release tag is present here:
> >>>>>>>>>
> >>>>>>>>
> >>>>>>
> >>>>
> >>
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
> >>>>>>>>>
> >>>>>>>>> This release includes the following changes:
> >>>>>>>>> • Added discv5
> >>>>>>>>> • Bytes fixes and enhancements
> >>>>>>>>> • Fixes and minor enhancements to UInt256
> >>>>>>>>>
> >>>>>>>>> Here’s my +1.
> >>>>>>>>>
> >>>>>>>>> Cheers,
> >>>>>>>>>
> >>>>>>>>> Antoine
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >> ---------------------------------------------------------------------
> >>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> ---------------------------------------------------------------------
> >>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>>>>
> >>>>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>>
> >>>>
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
Thanks Furkan.
The release vote has stalled. I’ll call it tomorrow unless more votes come in.
Cheers!
Antoine
> On Dec 2, 2019, at 12:08 PM, Furkan KAMACI <fu...@gmail.com> wrote:
>
> Hi Antoine,
>
> Thanks! Yes, it's been pointed at there, OK.
>
> Kind Regards,
> Furkan KAMACI
>
> On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name> wrote:
>
>> I wrote ProgPoW by myself, following the specification and seminal work by
>> Danno Ferrin.
>>
>> It’s under ASF copyright fair and square.
>>
>> The algorithm of ProgPoW is licensed under CCO, which was the cause of
>> concern as their reference implementation is non-ASL compatible.
>>
>> I therefore added a comment in the class explaining the provenance of the
>> algorithm:
>>
>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>> <
>> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
>>>
>>
>> You voted on those changes in release 0.8.2:
>>
>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>> <
>> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
>>>
>>
>> Please let me know if I need to do anything else.
>>
>> Cheers,
>>
>> Antoine
>>
>>> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
>> wrote:
>>>
>>> Hi Antoine,
>>>
>>> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>>>
>>> Kind Regards,
>>> Furkan KAMACI
>>>
>>> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
>> wrote:
>>>
>>>> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
>> 0.8.1,
>>>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>>>
>>>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> +1 from me.
>>>>>
>>>>> I checked:
>>>>>
>>>>> - Incubating in name
>>>>> - DISCLAIMER exists
>>>>> - LICENSE and NOTICE are fine
>>>>> - No unexpected binary files
>>>>> - Checked PGP signatures
>>>>> - Checked Checksums
>>>>> - Code compiles and tests successfully run
>>>>>
>>>>> Comments:
>>>>>
>>>>> 1) You should fix build instructions to include minimum required Java 8
>>>>> minor version.
>>>>> 2) Tidy up indentation of DISCLAIMER. See
>>>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>>>>> 3) Please be sure that "all" steps are OK at here:
>>>>>
>>>>
>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>>>>>
>>>>> Kind Regards,
>>>>> Furkan KAMACI
>>>>>
>>>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>>>> wrote:
>>>>>
>>>>>> You’re using a very old version of JDK8, and the later versions behave
>>>>>> differently.
>>>>>>
>>>>>> This tells me we need to move to Java 11.
>>>>>>
>>>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I still get the same error as previous version:
>>>>>>>
>>>>>>
>>>>
>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>>>>>
>>>>>>> Kind Regards,
>>>>>>> Furkan KAMACI
>>>>>>>
>>>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
>>>>>> wrote:
>>>>>>>
>>>>>>>> looks good
>>>>>>>> +1
>>>>>>>>
>>>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
>>>>>> wrote:
>>>>>>>>
>>>>>>>>> We're voting on the distributions available here:
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>>>>>> The release tag is present here:
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>>>>>
>>>>>>>>> This release includes the following changes:
>>>>>>>>> • Added discv5
>>>>>>>>> • Bytes fixes and enhancements
>>>>>>>>> • Fixes and minor enhancements to UInt256
>>>>>>>>>
>>>>>>>>> Here’s my +1.
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>>
>>>>>>>>> Antoine
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>> ---------------------------------------------------------------------
>>>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>
>>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>
>>>>
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi Antoine,
Thanks! Yes, it's been pointed at there, OK.
Kind Regards,
Furkan KAMACI
On Mon, Dec 2, 2019 at 10:48 PM Antoine Toulme <an...@toulme.name> wrote:
> I wrote ProgPoW by myself, following the specification and seminal work by
> Danno Ferrin.
>
> It’s under ASF copyright fair and square.
>
> The algorithm of ProgPoW is licensed under CCO, which was the cause of
> concern as their reference implementation is non-ASL compatible.
>
> I therefore added a comment in the class explaining the provenance of the
> algorithm:
>
> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
> <
> https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29
> >
>
> You voted on those changes in release 0.8.2:
>
> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
> <
> https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E
> >
>
> Please let me know if I need to do anything else.
>
> Cheers,
>
> Antoine
>
> > On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com>
> wrote:
> >
> > Hi Antoine,
> >
> > ProgPoW.java has the same header that's been fixed at SECP256K1.java?
> >
> > Kind Regards,
> > Furkan KAMACI
> >
> > On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
> wrote:
> >
> >> I made sure all steps were clear as of 3). That’s why I had 0.8.0,
> 0.8.1,
> >> 0.8.2. We went all over this. Which one do you see is not compliant?
> >>
> >>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> +1 from me.
> >>>
> >>> I checked:
> >>>
> >>> - Incubating in name
> >>> - DISCLAIMER exists
> >>> - LICENSE and NOTICE are fine
> >>> - No unexpected binary files
> >>> - Checked PGP signatures
> >>> - Checked Checksums
> >>> - Code compiles and tests successfully run
> >>>
> >>> Comments:
> >>>
> >>> 1) You should fix build instructions to include minimum required Java 8
> >>> minor version.
> >>> 2) Tidy up indentation of DISCLAIMER. See
> >>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
> >>> 3) Please be sure that "all" steps are OK at here:
> >>>
> >>
> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
> >>>
> >>> Kind Regards,
> >>> Furkan KAMACI
> >>>
> >>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
> >> wrote:
> >>>
> >>>> You’re using a very old version of JDK8, and the later versions behave
> >>>> differently.
> >>>>
> >>>> This tells me we need to move to Java 11.
> >>>>
> >>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
> >>>> wrote:
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> I still get the same error as previous version:
> >>>>>
> >>>>
> >>
> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
> >>>>>
> >>>>> Kind Regards,
> >>>>> Furkan KAMACI
> >>>>>
> >>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
> >>>> wrote:
> >>>>>
> >>>>>> looks good
> >>>>>> +1
> >>>>>>
> >>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
> >>>> wrote:
> >>>>>>
> >>>>>>> We're voting on the distributions available here:
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> >>>>>>> The release tag is present here:
> >>>>>>>
> >>>>>>
> >>>>
> >>
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
> >>>>>>>
> >>>>>>> This release includes the following changes:
> >>>>>>> • Added discv5
> >>>>>>> • Bytes fixes and enhancements
> >>>>>>> • Fixes and minor enhancements to UInt256
> >>>>>>>
> >>>>>>> Here’s my +1.
> >>>>>>>
> >>>>>>> Cheers,
> >>>>>>>
> >>>>>>> Antoine
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> ---------------------------------------------------------------------
> >>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>>
> >>>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>
> >>
>
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
I wrote ProgPoW by myself, following the specification and seminal work by Danno Ferrin.
It’s under ASF copyright fair and square.
The algorithm of ProgPoW is licensed under CCO, which was the cause of concern as their reference implementation is non-ASL compatible.
I therefore added a comment in the class explaining the provenance of the algorithm:
https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29 <https://github.com/apache/incubator-tuweni/blob/master/progpow/src/main/java/org/apache/tuweni/progpow/ProgPoW.java#L29>
You voted on those changes in release 0.8.2:
https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E <https://lists.apache.org/thread.html/462f6c76c9f3d9a7ea09e3cf6c46ded8e775cb52db4edf30f8d43f0c@%3Cdev.tuweni.apache.org%3E>
Please let me know if I need to do anything else.
Cheers,
Antoine
> On Dec 2, 2019, at 11:38 AM, Furkan KAMACI <fu...@gmail.com> wrote:
>
> Hi Antoine,
>
> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>
> Kind Regards,
> Furkan KAMACI
>
> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name> wrote:
>
>> I made sure all steps were clear as of 3). That’s why I had 0.8.0, 0.8.1,
>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>
>>> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>> wrote:
>>>
>>> Hi,
>>>
>>> +1 from me.
>>>
>>> I checked:
>>>
>>> - Incubating in name
>>> - DISCLAIMER exists
>>> - LICENSE and NOTICE are fine
>>> - No unexpected binary files
>>> - Checked PGP signatures
>>> - Checked Checksums
>>> - Code compiles and tests successfully run
>>>
>>> Comments:
>>>
>>> 1) You should fix build instructions to include minimum required Java 8
>>> minor version.
>>> 2) Tidy up indentation of DISCLAIMER. See
>>> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>>> 3) Please be sure that "all" steps are OK at here:
>>>
>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>>>
>>> Kind Regards,
>>> Furkan KAMACI
>>>
>>> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>> wrote:
>>>
>>>> You’re using a very old version of JDK8, and the later versions behave
>>>> differently.
>>>>
>>>> This tells me we need to move to Java 11.
>>>>
>>>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> I still get the same error as previous version:
>>>>>
>>>>
>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>>>
>>>>> Kind Regards,
>>>>> Furkan KAMACI
>>>>>
>>>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
>>>> wrote:
>>>>>
>>>>>> looks good
>>>>>> +1
>>>>>>
>>>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
>>>> wrote:
>>>>>>
>>>>>>> We're voting on the distributions available here:
>>>>>>>
>>>>>>
>>>>
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>>>> The release tag is present here:
>>>>>>>
>>>>>>
>>>>
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>>>
>>>>>>> This release includes the following changes:
>>>>>>> • Added discv5
>>>>>>> • Bytes fixes and enhancements
>>>>>>> • Fixes and minor enhancements to UInt256
>>>>>>>
>>>>>>> Here’s my +1.
>>>>>>>
>>>>>>> Cheers,
>>>>>>>
>>>>>>> Antoine
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>>>
>>>>>>>
>>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
Btw, thanks for your great effort to become compatible with ASF at releases!
Kind Regards,
Furkan KAMACI
On Mon, Dec 2, 2019 at 10:38 PM Furkan KAMACI <fu...@gmail.com>
wrote:
> Hi Antoine,
>
> ProgPoW.java has the same header that's been fixed at SECP256K1.java?
>
> Kind Regards,
> Furkan KAMACI
>
> On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name>
> wrote:
>
>> I made sure all steps were clear as of 3). That’s why I had 0.8.0, 0.8.1,
>> 0.8.2. We went all over this. Which one do you see is not compliant?
>>
>> > On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
>> wrote:
>> >
>> > Hi,
>> >
>> > +1 from me.
>> >
>> > I checked:
>> >
>> > - Incubating in name
>> > - DISCLAIMER exists
>> > - LICENSE and NOTICE are fine
>> > - No unexpected binary files
>> > - Checked PGP signatures
>> > - Checked Checksums
>> > - Code compiles and tests successfully run
>> >
>> > Comments:
>> >
>> > 1) You should fix build instructions to include minimum required Java 8
>> > minor version.
>> > 2) Tidy up indentation of DISCLAIMER. See
>> > https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
>> > 3) Please be sure that "all" steps are OK at here:
>> >
>> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>> >
>> > Kind Regards,
>> > Furkan KAMACI
>> >
>> > On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
>> wrote:
>> >
>> >> You’re using a very old version of JDK8, and the later versions behave
>> >> differently.
>> >>
>> >> This tells me we need to move to Java 11.
>> >>
>> >>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>> >> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> I still get the same error as previous version:
>> >>>
>> >>
>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>> >>>
>> >>> Kind Regards,
>> >>> Furkan KAMACI
>> >>>
>> >>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
>> >> wrote:
>> >>>
>> >>>> looks good
>> >>>> +1
>> >>>>
>> >>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
>> >> wrote:
>> >>>>
>> >>>>> We're voting on the distributions available here:
>> >>>>>
>> >>>>
>> >>
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>> >>>>> The release tag is present here:
>> >>>>>
>> >>>>
>> >>
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>> >>>>>
>> >>>>> This release includes the following changes:
>> >>>>> • Added discv5
>> >>>>> • Bytes fixes and enhancements
>> >>>>> • Fixes and minor enhancements to UInt256
>> >>>>>
>> >>>>> Here’s my +1.
>> >>>>>
>> >>>>> Cheers,
>> >>>>>
>> >>>>> Antoine
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>>
>> ---------------------------------------------------------------------
>> >>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> >>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>> >>>>>
>> >>>>>
>> >>>>
>> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> >> For additional commands, e-mail: dev-help@tuweni.apache.org
>> >>
>> >>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi Antoine,
ProgPoW.java has the same header that's been fixed at SECP256K1.java?
Kind Regards,
Furkan KAMACI
On Mon, Dec 2, 2019 at 10:17 PM Antoine Toulme <an...@toulme.name> wrote:
> I made sure all steps were clear as of 3). That’s why I had 0.8.0, 0.8.1,
> 0.8.2. We went all over this. Which one do you see is not compliant?
>
> > On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > +1 from me.
> >
> > I checked:
> >
> > - Incubating in name
> > - DISCLAIMER exists
> > - LICENSE and NOTICE are fine
> > - No unexpected binary files
> > - Checked PGP signatures
> > - Checked Checksums
> > - Code compiles and tests successfully run
> >
> > Comments:
> >
> > 1) You should fix build instructions to include minimum required Java 8
> > minor version.
> > 2) Tidy up indentation of DISCLAIMER. See
> > https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
> > 3) Please be sure that "all" steps are OK at here:
> >
> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
> >
> > Kind Regards,
> > Furkan KAMACI
> >
> > On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name>
> wrote:
> >
> >> You’re using a very old version of JDK8, and the later versions behave
> >> differently.
> >>
> >> This tells me we need to move to Java 11.
> >>
> >>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> I still get the same error as previous version:
> >>>
> >>
> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
> >>>
> >>> Kind Regards,
> >>> Furkan KAMACI
> >>>
> >>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
> >> wrote:
> >>>
> >>>> looks good
> >>>> +1
> >>>>
> >>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
> >> wrote:
> >>>>
> >>>>> We're voting on the distributions available here:
> >>>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> >>>>> The release tag is present here:
> >>>>>
> >>>>
> >>
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
> >>>>>
> >>>>> This release includes the following changes:
> >>>>> • Added discv5
> >>>>> • Bytes fixes and enhancements
> >>>>> • Fixes and minor enhancements to UInt256
> >>>>>
> >>>>> Here’s my +1.
> >>>>>
> >>>>> Cheers,
> >>>>>
> >>>>> Antoine
> >>>>>
> >>>>>
> >>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>>>
> >>>>>
> >>>>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
I made sure all steps were clear as of 3). That’s why I had 0.8.0, 0.8.1, 0.8.2. We went all over this. Which one do you see is not compliant?
> On Dec 2, 2019, at 11:15 AM, Furkan KAMACI <fu...@gmail.com> wrote:
>
> Hi,
>
> +1 from me.
>
> I checked:
>
> - Incubating in name
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - Checked PGP signatures
> - Checked Checksums
> - Code compiles and tests successfully run
>
> Comments:
>
> 1) You should fix build instructions to include minimum required Java 8
> minor version.
> 2) Tidy up indentation of DISCLAIMER. See
> https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
> 3) Please be sure that "all" steps are OK at here:
> https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
>
> Kind Regards,
> Furkan KAMACI
>
> On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name> wrote:
>
>> You’re using a very old version of JDK8, and the later versions behave
>> differently.
>>
>> This tells me we need to move to Java 11.
>>
>>> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
>> wrote:
>>>
>>> Hi,
>>>
>>> I still get the same error as previous version:
>>>
>> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>>>
>>> Kind Regards,
>>> Furkan KAMACI
>>>
>>> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
>> wrote:
>>>
>>>> looks good
>>>> +1
>>>>
>>>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
>> wrote:
>>>>
>>>>> We're voting on the distributions available here:
>>>>>
>>>>
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>>>> The release tag is present here:
>>>>>
>>>>
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>>>
>>>>> This release includes the following changes:
>>>>> • Added discv5
>>>>> • Bytes fixes and enhancements
>>>>> • Fixes and minor enhancements to UInt256
>>>>>
>>>>> Here’s my +1.
>>>>>
>>>>> Cheers,
>>>>>
>>>>> Antoine
>>>>>
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>>>
>>>>>
>>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
Comments:
1) You should fix build instructions to include minimum required Java 8
minor version.
2) Tidy up indentation of DISCLAIMER. See
https://github.com/apache/incubator-druid/blob/master/DISCLAIMER
3) Please be sure that "all" steps are OK at here:
https://lists.apache.org/thread.html/f49f288b6b630aecf15b3adf6674f2342b2cfccdee5dd6a82d34a9ed@%3Cgeneral.incubator.apache.org%3E
Kind Regards,
Furkan KAMACI
On Mon, Dec 2, 2019 at 8:52 PM Antoine Toulme <an...@toulme.name> wrote:
> You’re using a very old version of JDK8, and the later versions behave
> differently.
>
> This tells me we need to move to Java 11.
>
> > On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com>
> wrote:
> >
> > Hi,
> >
> > I still get the same error as previous version:
> >
> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
> >
> > Kind Regards,
> > Furkan KAMACI
> >
> > On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com>
> wrote:
> >
> >> looks good
> >> +1
> >>
> >> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name>
> wrote:
> >>
> >>> We're voting on the distributions available here:
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> >>> The release tag is present here:
> >>>
> >>
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
> >>>
> >>> This release includes the following changes:
> >>> • Added discv5
> >>> • Bytes fixes and enhancements
> >>> • Fixes and minor enhancements to UInt256
> >>>
> >>> Here’s my +1.
> >>>
> >>> Cheers,
> >>>
> >>> Antoine
> >>>
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >>> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>>
> >>>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
You’re using a very old version of JDK8, and the later versions behave differently.
This tells me we need to move to Java 11.
> On Dec 2, 2019, at 9:17 AM, Furkan KAMACI <fu...@gmail.com> wrote:
>
> Hi,
>
> I still get the same error as previous version:
> https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
>
> Kind Regards,
> Furkan KAMACI
>
> On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com> wrote:
>
>> looks good
>> +1
>>
>> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name> wrote:
>>
>>> We're voting on the distributions available here:
>>>
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>>> The release tag is present here:
>>>
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>>
>>> This release includes the following changes:
>>> • Added discv5
>>> • Bytes fixes and enhancements
>>> • Fixes and minor enhancements to UInt256
>>>
>>> Here’s my +1.
>>>
>>> Cheers,
>>>
>>> Antoine
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
I still get the same error as previous version:
https://lists.apache.org/thread.html/95256d891a80a3bb9edabddebe8bddf6a3ad246b541a6b75665d10a2@%3Cdev.tuweni.apache.org%3E
Kind Regards,
Furkan KAMACI
On Mon, Dec 2, 2019 at 5:49 PM Jonny Rhea <jo...@gmail.com> wrote:
> looks good
> +1
>
> On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name> wrote:
>
> > We're voting on the distributions available here:
> >
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> > The release tag is present here:
> >
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
> >
> > This release includes the following changes:
> > • Added discv5
> > • Bytes fixes and enhancements
> > • Fixes and minor enhancements to UInt256
> >
> > Here’s my +1.
> >
> > Cheers,
> >
> > Antoine
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> > For additional commands, e-mail: dev-help@tuweni.apache.org
> >
> >
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Jonny Rhea <jo...@gmail.com>.
looks good
+1
On Sat, Nov 30, 2019, 7:47 PM Antoine Toulme <an...@toulme.name> wrote:
> We're voting on the distributions available here:
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> The release tag is present here:
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>
> This release includes the following changes:
> • Added discv5
> • Bytes fixes and enhancements
> • Fixes and minor enhancements to UInt256
>
> Here’s my +1.
>
> Cheers,
>
> Antoine
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Mikhail Kalinin <no...@gmail.com>.
Time is always an issue.
+1 to release!
On Mon, Dec 2, 2019 at 2:19 PM Antoine Toulme <an...@toulme.name> wrote:
> No time, really. You’re welcome to try. I’ll get to it.
>
> > On Dec 2, 2019, at 12:19 AM, Mikhail Kalinin <no...@gmail.com>
> wrote:
> >
> > Did you interop with geth implementation of discv5?
> >
> > On Sun, Dec 1, 2019 at 7:47 AM Antoine Toulme <an...@toulme.name>
> wrote:
> >
> >> We're voting on the distributions available here:
> >>
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> >> The release tag is present here:
> >>
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
> >>
> >> This release includes the following changes:
> >> • Added discv5
> >> • Bytes fixes and enhancements
> >> • Fixes and minor enhancements to UInt256
> >>
> >> Here’s my +1.
> >>
> >> Cheers,
> >>
> >> Antoine
> >>
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> >> For additional commands, e-mail: dev-help@tuweni.apache.org
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Antoine Toulme <an...@toulme.name>.
No time, really. You’re welcome to try. I’ll get to it.
> On Dec 2, 2019, at 12:19 AM, Mikhail Kalinin <no...@gmail.com> wrote:
>
> Did you interop with geth implementation of discv5?
>
> On Sun, Dec 1, 2019 at 7:47 AM Antoine Toulme <an...@toulme.name> wrote:
>
>> We're voting on the distributions available here:
>> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
>> The release tag is present here:
>> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>>
>> This release includes the following changes:
>> • Added discv5
>> • Bytes fixes and enhancements
>> • Fixes and minor enhancements to UInt256
>>
>> Here’s my +1.
>>
>> Cheers,
>>
>> Antoine
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [VOTE] Tuweni 0.10.0-incubating release
Posted by Mikhail Kalinin <no...@gmail.com>.
Did you interop with geth implementation of discv5?
On Sun, Dec 1, 2019 at 7:47 AM Antoine Toulme <an...@toulme.name> wrote:
> We're voting on the distributions available here:
> https://dist.apache.org/repos/dist/dev/incubator/tuweni/0.10.0-incubating/
> The release tag is present here:
> https://github.com/apache/incubator-tuweni/releases/tag/v0.10.0-incubating
>
> This release includes the following changes:
> • Added discv5
> • Bytes fixes and enhancements
> • Fixes and minor enhancements to UInt256
>
> Here’s my +1.
>
> Cheers,
>
> Antoine
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>