You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/22 09:06:49 UTC

[GitHub] [incubator-kyuubi] JeremyTon opened a new pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

JeremyTon opened a new pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Currently, we force it to hostname, this is not right.
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] zwangsheng commented on pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

Posted by GitBox <gi...@apache.org>.
zwangsheng commented on pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604#issuecomment-999488971


   thanks for the contribution! How about adding a few test cases to this function?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604#discussion_r773764469



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiRestFrontendService.scala
##########
@@ -76,7 +76,11 @@ class KyuubiRestFrontendService(override val serverable: Serverable)
 
   override def connectionUrl: String = {
     checkInitialized()
-    s"${serverAddr.getCanonicalHostName}:$portNum"
+    conf.get(FRONTEND_REST_BIND_HOST) match {

Review comment:
       shall we also update line 47 in `initialize` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604#issuecomment-999521972


   https://github.com/apache/incubator-kyuubi/pull/1602 maybe we shall simply follow this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604#issuecomment-999450043


   thank you @JeremyTon for the contribution ! also cc @zwangsheng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604#issuecomment-1059971047


   this is fixed, i will close this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1604: [KYUUBI #1564] fix Server connectionUrl force to hostname

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1604:
URL: https://github.com/apache/incubator-kyuubi/pull/1604


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org