You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jeff Hodges (JIRA)" <ji...@apache.org> on 2009/05/04 15:34:30 UTC

[jira] Created: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

`show config file` in cli causes server to throw NPE 
-----------------------------------------------------

                 Key: CASSANDRA-129
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
             Project: Cassandra
          Issue Type: Bug
         Environment: OS X, Java 1.7 (via soylatte)
            Reporter: Jeff Hodges


Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.

The error in question:

ERROR - Error occurred during processing of message.
java.lang.NullPointerException
	at java.io.FileInputStream.<init>(FileInputStream.java:133)
	at java.io.FileInputStream.<init>(FileInputStream.java:96)
	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
	at java.lang.Thread.run(Thread.java:713)



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706272#action_12706272 ] 

Jeff Hodges commented on CASSANDRA-129:
---------------------------------------

Ah, shoot. Too slow at writing the test for this, I guess.

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Assignee: Sandeep Tata
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch, config_file_name.pach
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706273#action_12706273 ] 

Sandeep Tata commented on CASSANDRA-129:
----------------------------------------

+1 :-)

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Assignee: Sandeep Tata
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch, config_file_name.pach
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hodges updated CASSANDRA-129:
----------------------------------

    Attachment: config_file_name.pach

Patch from Sandeep for config flie plus unit test.

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Assignee: Sandeep Tata
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch, config_file_name.pach
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706889#action_12706889 ] 

Hudson commented on CASSANDRA-129:
----------------------------------

Integrated in Cassandra #63 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/63/])
    

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Assignee: Sandeep Tata
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch, config_file_name.pach
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata updated CASSANDRA-129:
-----------------------------------

    Attachment: 129.patch

Reproduced the error.
The config file wasn't being initialized. This patch should fix that.

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Jeff Hodges (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hodges updated CASSANDRA-129:
----------------------------------

    Priority: Minor  (was: Major)

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Priority: Minor
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706282#action_12706282 ] 

Jonathan Ellis commented on CASSANDRA-129:
------------------------------------------

committed Jeff's test, too.  thanks!

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Assignee: Sandeep Tata
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch, config_file_name.pach
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-129) `show config file` in cli causes server to throw NPE

Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sandeep Tata reassigned CASSANDRA-129:
--------------------------------------

    Assignee: Sandeep Tata

> `show config file` in cli causes server to throw NPE 
> -----------------------------------------------------
>
>                 Key: CASSANDRA-129
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-129
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: trunk
>         Environment: OS X, Java 1.7 (via soylatte)
>            Reporter: Jeff Hodges
>            Assignee: Sandeep Tata
>            Priority: Minor
>             Fix For: trunk
>
>         Attachments: 129.patch
>
>
> Booting up the cli and running the command "show config file" in the lastest from trunk (r771019) on a fresh and empty cassandra instance causes a NullPointerError to be thrown. By looking at the code (but being a not-so-hot java developer), it looks like the problem is simply DatabaseDescriptor.getConfigFileName() returning a null because configFileName_ never gets set anywhere in the code.
> The error in question:
> ERROR - Error occurred during processing of message.
> java.lang.NullPointerException
> 	at java.io.FileInputStream.<init>(FileInputStream.java:133)
> 	at java.io.FileInputStream.<init>(FileInputStream.java:96)
> 	at org.apache.cassandra.service.CassandraServer.getStringProperty(CassandraServer.java:485)
> 	at org.apache.cassandra.service.Cassandra$Processor$getStringProperty.process(Cassandra.java:1294)
> 	at org.apache.cassandra.service.Cassandra$Processor.process(Cassandra.java:860)
> 	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:252)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
> 	at java.lang.Thread.run(Thread.java:713)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.