[jira] [Commented] (LUCENE-9114) Add FunctionValues.cost

["Atri Sharma (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048492#comment-17048492 ] 

Atri Sharma commented on LUCENE-9114:
-------------------------------------

[~dsmiley] I have raised a PR for the same -- it is a minimalistic change to allow VSS to incorporate the delegated FunctionValues's cost into its cost. Would that help you get unblocked by adding stacked FunctionValues with custom costing functions?

> Add FunctionValues.cost
> -----------------------
>
>                 Key: LUCENE-9114
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9114
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/query
>            Reporter: David Smiley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The FunctionRangeQuery uses FunctionValues.getRangeScorer which returns a subclass of  ValueSourceScorer.  VSC's TwoPhaseIterator has a matchCost impl that returns a constant 100.  This is pretty terrible; the cost should vary based on the complexity of the ValueSource provided to FRQ.  ValueSource's are typically nested a number of levels, so they should aggregate.
> BTW there is a parallel concern for FunctionMatchQuery which works with DoubleValuesSource which doesn't have a cost either, and unsurprisingly there is a TPI with matchCost 100 there.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org