You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/19 16:14:47 UTC
[GitHub] [cloudstack] SadiJr opened a new pull request, #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
SadiJr opened a new pull request, #5902:
URL: https://github.com/apache/cloudstack/pull/5902
### Description
The default behavior of ACS is to try to use all available public IPs, including those reserved for system VMs; by default when a public IP is reserved to System VM, they are used as preferred to be allocated to system VMs, but not restricted to these type of VMs. This behavior can be changed by changing the value of the global setting `system.vm.public.ip.reservation.mode.strictness` from false to true. However, if an IP reserved for system VMs is already in use for a user VR, the parameter change will make the IP to be hidden from the user, which can lead to all sorts of confusion. Therefore, this PR is intended to address these situations.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### How Has This Been Tested?
It was tested in a local lab:
1. I allocated a range of 10 IPs to System VMs with `system.vm.public.ip.reservation.mode.strictness` as false;
2. I allocated all the other IPs to another network;
3. I created a new network and started a new VM with this network;
4. Then I changed the `system.vm.public.ip.reservation.mode.strictness` to true;
5. Before the changes, in the VR details (UI), there is no IP information;
6. With this PR, the user can see correctly the IP.
Also, I added new unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1099468343
<b>Trillian test result (tid-3909)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32452 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5902-t3909-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098487583
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a diff in pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
SadiJr commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r846007390
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO> sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null && IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review Comment:
Hi @weizhouapache
I apologize for the delay in my answer. I've been pretty busy the last few weeks, and I ended up not having time to review this PR. I will implement and test your suggestion. Thanks for the suggestion and I apologize again for the delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1091109746
Hi @${author}, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098848410
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098789296
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101605643
@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098487998
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101605008
Found Java/XML changes, kicking packaging job
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a diff in pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
SadiJr commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r849890394
##########
server/src/main/java/com/cloud/network/IpAddressManagerImpl.java:
##########
@@ -304,7 +304,7 @@
static Boolean rulesContinueOnErrFlag = true;
- private static final ConfigKey<Boolean> SystemVmPublicIpReservationModeStrictness = new ConfigKey<Boolean>("Advanced",
+ public static ConfigKey<Boolean> SystemVmPublicIpReservationModeStrictness = new ConfigKey<Boolean>("Advanced",
Review Comment:
Done, thanks for the suggestion and sorry for the delay in answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101655919
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r848696111
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO> sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null && IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review Comment:
@SadiJr
no problem. thanks for your reply.
The 4.17.0.0 code freeze date is very close. If you want this PR to be included, please update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on a diff in pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
SadiJr commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r849891690
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO> sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null && IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review Comment:
Done, thanks for the suggestion and sorry for the delay in answer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1102175149
@SadiJr
the travis smoke test `test_portable_publicip` failed, it seems to be related to this PR.
```
Currently running test: smoke/test_portable_publicip
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp/MarvinLogs/Apr_18_2022_23_17_26_IICLVA All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_createPortablePublicIPAcquire | Status : EXCEPTION ===
=== TestName: test_createPortablePublicIPRange | Status : EXCEPTION ===
=== Final results are now copied to: /tmp/MarvinLogs/test_portable_publicip_UW5HUH ===
real 0m9.150s
user 0m0.841s
sys 0m0.068s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1102159566
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
SadiJr commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101604136
@weizhouapache
I did some more tests, and everything is working good. I also checked that, with the setting as `true`, when releasing a reserved IP from the system VMs (but in use by a user VM), it is correctly excluded from the listing and it is also not possible for the user to reallocate it via cmk . Also, I created a new commit with your changes.
Again, thank you very much for your testing and your help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098507239
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 3165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r850219465
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO> sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null && IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review Comment:
@SadiJr
thanks for update. I will review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098790125
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098849000
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1102814944
<b>Trillian test result (tid-3929)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30904 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5902-t3929-kvm-centos7.zip
Smoke tests completed. 93 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache merged pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache merged PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1099469557
@SadiJr
I have tested this PR. unforunately the issue you mentioned in description is not fixed.
I have made some changes to your code. see https://github.com/weizhouapache/cloudstack/commit/18137e105cefbc163a1bf8cad4961c30239762dd
what I have tested are
1. global setting `system.vm.public.ip.reservation.mode.strictness` is set to `false`
- 1.1 Free IPs in the range can be listed (OK to me)
- 1.2 Free IPs in the range can be associated to isolated networks (OK to me)
- 1.3 Allocated IPs (in step 1.2) are listed in the "Public IP Addresses" tab in the network details page. (OK to me)
2. global setting `system.vm.public.ip.reservation.mode.strictness` is set to `true`
- 2.1 Free IPs in the range can NOT be listed (OK to me)
- 2.2 Free IPs in the range can NOT be associated to isolated networks by `cmk` (OK to me)
- 2.3 Allocated IPs (in step 1.2) are listed in the "Public IP Addresses" tab in the network details page. (OK to me)
other than that, I change the global configuration to dynamic, so it is not required to restart management server when you change the value.
Could you please test it ? If it works, please advise if you add the commit to your PR or I create a new PR which including all changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1098836403
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
SadiJr commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101339232
@weizhouapache thanks for yours tests and your help. I will implement your suggestions and test them. If all goes well, I'll add a new commit with your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101604998
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1102158376
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1101642043
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
|ClusteredAgentManagerImpl|2361|0|242|0|536|0|
|DefaultVMSnapshotStrategy|486|677|52|30|100|140|
|LibvirtVMDef|37|114|6|4|11|36|
||
|VmwareManagerImpl|2613|528|296|38|615|117|
|VmwareStorageProcessor|9886|9|940|0|2121|2|
|NetScalerControlCenterResource|1943|0|144|0|468|0|
|NetscalerResource|6882|0|806|0|1623|0|
|DateraPrimaryDataStoreDriver|3195|0|283|0|748|0|
|CloudStackPrimaryDataStoreDriverImpl|903|0|114|0|229|0|
|LinstorPrimaryDataStoreDriverImpl|1442|0|91|0|348|0|
||
||
|ScaleIOPrimaryDataStoreDriver|2537|0|246|0|537|0|
|SolidFirePrimaryDataStoreDriver|3347|0|284|0|697|0|
|SAMLUtils|202|465|41|11|53|108|
|Config|152|5162|30|6|42|342|
|IpAddressManagerImpl|4045|0|461|0|806|0|
|ManagementServerImpl|11774|0|1052|0|2350|0|
|VolumeApiServiceImpl|10826|0|1498|0|2031|0|
|SnapshotManagerImpl|4186|0|410|0|751|0|
|TaggedResourceManagerImpl|473|0|58|0|96|0|
|AccountManagerImpl|6427|0|900|0|1348|0|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|PremiumSecondaryStorageManagerImpl|775|0|64|0|116|0|
|SecondaryStorageManagerImpl|3494|149|343|11|623|32|
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #5902: Allow users to view reserved System VM IPs, if they're already allocated to user
URL: https://github.com/apache/cloudstack/pull/5902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org