[GitHub] cjolivier01 commented on a change in pull request #9349: Fix C++ unit tests

[GitBox <gi...@apache.org>]

cjolivier01 commented on a change in pull request #9349: Fix C++ unit tests
URL: https://github.com/apache/incubator-mxnet/pull/9349#discussion_r161260225
 
 

 ##########
 File path: CMakeLists.txt
 ##########
 @@ -201,9 +201,13 @@ include_directories("dlpack/include")
 #  add_subdirectory(dlpack)
 #endif()
 
+# Prevent stripping out symbols (operator registrations, for example)
 if(NOT MSVC AND NOT APPLE)
   set(BEGIN_WHOLE_ARCHIVE -Wl,--whole-archive)
   set(END_WHOLE_ARCHIVE -Wl,--no-whole-archive)
+elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  # using regular Clang or AppleClang
+  set(BEGIN_WHOLE_ARCHIVE -Wl,-force_load)
 
 Review comment:
   nit: in the interest of completeness and readability, it would be nice to have a set(END_WHOLE_ARCHIVE "") here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services