You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/20 23:59:38 UTC

Review Request 55804: Added new master metric, "unreachable_slaves".

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55804/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Repository: mesos


Description
-------

This reports the number of unreachable agents the master is
tracking. Because the master GCs the list of unreachable agents, this
might be smaller than the number of agents that have been marked
unreachable and never re-registered.


Diffs
-----

  docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222 
  src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 
  src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b 
  src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
  src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32 
  src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494 
  src/tests/partition_tests.cpp e7f64182f39dfdf15d035b43c18bf58aecfc74d1 

Diff: https://reviews.apache.org/r/55804/diff/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 55804: Added new master metric, "unreachable_slaves".

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55804/#review162745
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Jan. 20, 2017, 11:59 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55804/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 11:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reports the number of unreachable agents the master is
> tracking. Because the master GCs the list of unreachable agents, this
> might be smaller than the number of agents that have been marked
> unreachable and never re-registered.
> 
> 
> Diffs
> -----
> 
>   docs/monitoring.md f32ee40278afea60f8b1a836798d6fe063d1f222 
>   src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 
>   src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b 
>   src/master/master.cpp 73159328ce3fd838e02eba0e6a30cf69efc319ba 
>   src/master/metrics.hpp 056d290c1e14a6afd5056873ef7bb07b5892ed32 
>   src/master/metrics.cpp 1f049f3794c1bca45d2684cbbec3b08c1a78c494 
>   src/tests/partition_tests.cpp e7f64182f39dfdf15d035b43c18bf58aecfc74d1 
> 
> Diff: https://reviews.apache.org/r/55804/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>