[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5902: feat: Implement the bitwise_not in NotExpr

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5902:
URL: https://github.com/apache/arrow-datafusion/pull/5902#discussion_r1161899983


##########
datafusion/core/tests/sql/expr.rs:
##########
@@ -622,6 +622,17 @@ async fn test_not_expressions() -> Result<()> {
     ];
     assert_batches_eq!(expected, &actual);
 
+    let sql = "SELECT not(1), not(0)";
+    let actual = execute_to_batches(&ctx, sql).await;

Review Comment:
   I agree it would be nice to move to https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/sqllogictests/test_files/scalar.slt but we can do that potentially as a follow on PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org