You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/03 20:28:07 UTC

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #768: HDDS-3341. Checkstyle fails for new modules/versions

adoroszlai opened a new pull request #768: HDDS-3341. Checkstyle fails for new modules/versions
URL: https://github.com/apache/hadoop-ozone/pull/768

## What changes were proposed in this pull request?

Make `checkstyle.sh` work with new modules/versions:

1. first attempt to run the check only
2. if it fails due to anything other than style violation, try to compile sources, too.

Ignore violations on Protobuf generated sources.

Output from the first attempt is only printed with some delay only if and when it completes successfully, to avoid duplicate Maven logs. This may be a bit annoying when run manually. Please let me know if duplicated but immediate output is preferred.

https://issues.apache.org/jira/browse/HDDS-3341

## How was this patch tested?

1. Tested on HDDS-3312, which introduces a new `hadoop-hdds-hadoop-dependency-client` module and [fails](https://github.com/apache/hadoop-ozone/pull/744/checks?check_run_id=558258406) with `Could not find artifact org.apache.hadoop:hadoop-hdds-hadoop-dependency-client:jar:0.6.0-SNAPSHOT in apache.snapshots.https`. With this change the check passes:

2. Tested on `master`, where all modules are available, so no compilation is needed:

3. Introduced an unused import, verified that violation is reported:

```
$ hadoop-ozone/dev-support/checks/checkstyle.sh
...
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.226 s
...
hadoop-ozone/common/src/main/java/org/apache/hadoop/hdds/protocol/StorageType.java
20: Unused import - java.util.List.
$ echo $?
1
```

https://github.com/adoroszlai/hadoop-ozone/runs/558999926

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #768: HDDS-3341. Checkstyle fails for new modules/versions

Posted by GitBox <gi...@apache.org>.

dineshchitlangia merged pull request #768: HDDS-3341. Checkstyle fails for new modules/versions
URL: https://github.com/apache/hadoop-ozone/pull/768
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] elek commented on issue #768: HDDS-3341. Checkstyle fails for new modules/versions

Posted by GitBox <gi...@apache.org>.

elek commented on issue #768: HDDS-3341. Checkstyle fails for new modules/versions
URL: https://github.com/apache/hadoop-ozone/pull/768#issuecomment-609054875
 
 
   Good trick. 
   
   The related problem is that our daily build is failing on the apache jenkins (which did the deploy) and our github daily build doesn't have permission to upload to the apache snapshot repository. We might need to ask INFRA to set a secret to make it possible to deploy. (Which would make the original problem more rare)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] adoroszlai commented on issue #768: HDDS-3341. Checkstyle fails for new modules/versions

Posted by GitBox <gi...@apache.org>.

adoroszlai commented on issue #768: HDDS-3341. Checkstyle fails for new modules/versions
URL: https://github.com/apache/hadoop-ozone/pull/768#issuecomment-608982277
 
 
   Thanks @dineshchitlangia for reviewing and merging this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org