You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/06/02 12:36:36 UTC

[Impala-CR](cdh5-trunk) PREVIEW IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3286

Change subject: PREVIEW IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................

PREVIEW IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused by glog's
own stack unwinding mechanism, which catches SIGABRT and removes all other handlers before
aborting.

This change bumps the glog version to include a patch, which backports a change from glog,
which only resets the SIGABRT handler, if it is the one installed by glog itself.

https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe

Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
---
M bin/impala-config.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/3286/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 3:

(1 comment)

Thanks Michael for the review. Please see my reply and PS4.

http://gerrit.cloudera.org:8080/#/c/3286/3/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

PS3, Line 195:   @pytest.mark.execute_serially
             :   def test_dcheck_writes_minidump(self):
             :     """Check that hitting a DCHECK macro writes a minidump."""
> Will this test pass if Impala is a release build?
Yes, it will pass. I wasn't sure, so I checked and the bind() call fails, thus also triggering a minidump write. However it does not really test the DCHECK in this case, so I disabled the test on non-dev builds.


-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.

Michael Brown has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3286/4/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

PS4, Line 209:     # Kill the rest of the cluster.
             :     self.kill_cluster(SIGKILL)
It would be better not to have cleanup actions in tests. Is this needed before teardown_method() gets called?


-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 2:

It's OK if you think this is too much work, but you could just start an impalad with the server ports set to 0 (via gflags)? See impala-server.cc:1813.

-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has uploaded a new patch set (#5).

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................

IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused by glog's
own stack unwinding mechanism, which catches SIGABRT and removes all other handlers before
aborting.

This change bumps the glog version to include a patch, which backports a change from glog,
which only resets the SIGABRT handler, if it is the one installed by glog itself.

https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe

Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
---
M bin/impala-config.sh
M tests/custom_cluster/test_breakpad.py
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/3286/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Hello Michael Brown, Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3286

to look at the new patch set (#7).

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................

IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

When hitting a DCHECK/CHECK the daemons do not write minidumps. This is
caused by glog's own stack unwinding mechanism, which catches SIGABRT
and removes all other handlers before aborting.

This change bumps the glog version to include a patch, which backports a
change from glog, which only resets the SIGABRT handler, if it is the
one installed by glog itself.

https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe

Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
---
M bin/impala-config.sh
M tests/custom_cluster/test_breakpad.py
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/3286/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Hello Michael Brown,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3286

to look at the new patch set (#6).

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................

IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused by glog's
own stack unwinding mechanism, which catches SIGABRT and removes all other handlers before
aborting.

This change bumps the glog version to include a patch, which backports a change from glog,
which only resets the SIGABRT handler, if it is the one installed by glog itself.

https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe

Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
---
M bin/impala-config.sh
M tests/custom_cluster/test_breakpad.py
2 files changed, 16 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/86/3286/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has submitted this change and it was merged.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

When hitting a DCHECK/CHECK the daemons do not write minidumps. This is
caused by glog's own stack unwinding mechanism, which catches SIGABRT
and removes all other handlers before aborting.

This change bumps the glog version to include a patch, which backports a
change from glog, which only resets the SIGABRT handler, if it is the
one installed by glog itself.

https://github.com/google/glog/commit/cda16b3443e2d6ef88cdbbe10b9a11adea6f33fe

Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Reviewed-on: http://gerrit.cloudera.org:8080/3286
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M bin/impala-config.sh
M tests/custom_cluster/test_breakpad.py
2 files changed, 16 insertions(+), 1 deletion(-)

Approvals:
  Lars Volker: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.

Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3286/6//COMMIT_MSG
Commit Message:

PS6, Line 9: When hitting a DCHECK/CHECK the daemons do not write minidumps. This is caused by glog's
           : own stack unwinding mechanism, which catches SIGABRT and removes all other handlers before
           : aborting.
           : 
           : This change bumps the glog version to include a patch, which backports a change from glog,
           : which only resets the SIGABRT handler, if it is the one installed by glog itself.
nit: can you wrap this, maybe to 72 cols?


-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.

Michael Ho has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 2:

Just wondering if the patch or the new binary has been checked into s3 yet ? I just tried running bootstrap_toolchain.py with -p2 for glog and it failed to download it.

-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 4:

(1 comment)

Thanks for the review, please see PS5.

http://gerrit.cloudera.org:8080/#/c/3286/4/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

PS4, Line 209:     # Kill the rest of the cluster.
             :     self.kill_cluster(SIGKILL)
> It would be better not to have cleanup actions in tests. Is this needed bef
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 6:

Private jenkins run for this change: http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1627/

-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 2:

Thanks for the review. I added a test to PS3.

-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.

Michael Brown has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 5: Code-Review+1

The test looks fine. Please get others' buy in for glog-0.3.2-p2.

-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 7: Code-Review+2 Verified+1

+2 from Matt, +1 from Michael

Jenkins job validated PS6 (custom cluster, hdfs, debug): http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1627/

-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 7
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-HasComments: No

[Impala-CR](cdh5-trunk) IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change.

Change subject: IMPALA-3656: Hitting DCHECK/CHECK does not write minidumps
......................................................................


Patch Set 1:

(1 comment)

Thanks for the review. I uploaded PS2.

I tested this manually by inserting a DCHECK(false) after the breakpad initialization and started a daemon, which then wrote a minidump. Before the glog patch it would not do so.

Do we have a way to trigger code execution of particular functions during tests but strip from production builds? Other than that I wouldn't know how to automatically test this.

http://gerrit.cloudera.org:8080/#/c/3286/1//COMMIT_MSG
Commit Message:

PS1, Line 7: PREVIEW
> This is no longer a preview, right? Remove please
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3286
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e6b83af1b4ff1b8c916fe6c9052b88b760e188
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: Yes