You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2023/09/19 21:17:09 UTC
[GitHub] [beam] ahmedabu98 commented on a diff in pull request #28540: Label Python external SchemaTransform with its URN
ahmedabu98 commented on code in PR #28540:
URL: https://github.com/apache/beam/pull/28540#discussion_r1330710410
##########
sdks/python/apache_beam/transforms/external.py:
##########
@@ -414,7 +414,7 @@ def __init__(
def expand(self, pcolls):
# Expand the transform using the expansion service.
- return pcolls | ExternalTransform(
+ return pcolls | self._payload_builder._identifier >> ExternalTransform(
Review Comment:
I can't find documentation on what the standard is for PTransform labels, but I tried the Storage API xlang wrapper with URN `beam:schematransform:org.apache.beam:bigquery_storage_write:v2` and it shows up fine on the Dataflow DAG:

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org