[GitHub] eolivelli commented on a change in pull request #495: Issue 494: Rename ZkVersion to LongVersion

[gi...@git.apache.org]

eolivelli commented on a change in pull request #495: Issue 494: Rename ZkVersion to LongVersion
URL: https://github.com/apache/bookkeeper/pull/495#discussion_r137521090
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java
 ##########
 @@ -268,12 +267,12 @@ public void removeLedgerMetadata(final long ledgerId, final Version version,
             cb.operationComplete(BKException.Code.MetadataVersionException, (Void)null);
             return;
         } else if (Version.ANY != version) {
-            if (!(version instanceof ZkVersion)) {
+            if (!(version instanceof LongVersion)) {
                 LOG.info("Not an instance of ZKVersion: {}", ledgerId);
                 cb.operationComplete(BKException.Code.MetadataVersionException, (Void)null);
                 return;
             } else {
-                znodeVersion = ((ZkVersion)version).getZnodeVersion();
+                znodeVersion = (int) ((LongVersion) version).getLongVersion();
 
 Review comment:
   the (int) cast sounds a bit weird, but for me it is OK, it is not possible to do it in other way without deep changes.
   this patch is all a "rename"
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services