[GitHub] [incubator-brpc] wwbmmm commented on pull request #1751: butex_wake_all support nosched flag

[GitBox <gi...@apache.org>]

wwbmmm commented on PR #1751:
URL: https://github.com/apache/incubator-brpc/pull/1751#issuecomment-1127144707

   > nosched参数是不是可以去掉了，如果nosignal是true，就不要调用exchange，而是调用ready_to_run 另外，我觉得exchange里面的nosignal=true会有问题，因为当前协程切出去了，再次回来需要一个flush，这个flush不知道谁去执行。这和其它地方的nosignal不一样，其它地方都是本协程唤醒其它协程，最后执行一次flush
   
   你的意思是只需要支持nosched=true && nosignal=true 和 nosched=false && nosignal=false这两种场景是吗？
   如果暂时没有nosched=true && nosignal=false和nosched=false && nosignal=true这两种场景的需求，也可以先去掉nosched参数。将来有需求再添加


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org