You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "williamhyun (via GitHub)" <gi...@apache.org> on 2025/06/30 20:30:29 UTC
[PR] Create Delegation Service Module [polaris]
williamhyun opened a new pull request, #1981:
URL: https://github.com/apache/polaris/pull/1981
This PR aims to set up the Delegation Service module for development.
Discussion thread:
- https://lists.apache.org/thread/ph10th4ocjczpf5gz17mqys4fkp5qrzw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on code in PR #1981:
URL: https://github.com/apache/polaris/pull/1981#discussion_r2193498561
##########
delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.delegation.api;
+
+import jakarta.validation.Valid;
+import jakarta.validation.constraints.NotNull;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
+import org.apache.polaris.delegation.api.model.TaskExecutionRequest;
+import org.apache.polaris.delegation.api.model.TaskExecutionResponse;
+import org.apache.polaris.delegation.api.model.TaskType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * REST API for the Polaris Delegation Service.
+ *
+ * <p>Provides endpoints for submitting long-running tasks for synchronous execution. This API
+ * allows the main Polaris catalog to offload resource-intensive operations to maintain low-latency
+ * performance.
+ *
+ * <p><strong>Note:</strong> This is the initial API framework implementation. The actual task
+ * execution logic will be implemented in future development phases.
+ */
+@Path("/api/v1/tasks/execute")
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+public class DelegationApi {
Review Comment:
Thank you @jbonofre for your concern! As @eric-maynard has mentioned, the task executor for delegating to the remote service can be flagged as experimental.
In regards to illustrating how it would all work, an end-to-end test is in preparation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #1981:
URL: https://github.com/apache/polaris/pull/1981#issuecomment-3051881000
The question is which approach two use. There are _two_ proposals on the dev-ML, with no technical pro/con discussion and therefore no decision. As mentioned in other discussions, things do take time. The whole topic is too sensitive and needs to be handled carefully, considering all aspects.
Having one proposal not receiving comments and weeks after another, different counter-proposal plus a concrete implementation is not great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1981:
URL: https://github.com/apache/polaris/pull/1981#discussion_r2192981115
##########
delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.delegation.api;
+
+import jakarta.validation.Valid;
+import jakarta.validation.constraints.NotNull;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
+import org.apache.polaris.delegation.api.model.TaskExecutionRequest;
+import org.apache.polaris.delegation.api.model.TaskExecutionResponse;
+import org.apache.polaris.delegation.api.model.TaskType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * REST API for the Polaris Delegation Service.
+ *
+ * <p>Provides endpoints for submitting long-running tasks for synchronous execution. This API
+ * allows the main Polaris catalog to offload resource-intensive operations to maintain low-latency
+ * performance.
+ *
+ * <p><strong>Note:</strong> This is the initial API framework implementation. The actual task
+ * execution logic will be implemented in future development phases.
+ */
+@Path("/api/v1/tasks/execute")
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+public class DelegationApi {
Review Comment:
This isn't a Polaris API, and within the context of the delegation service (itself experimental), this is not really an experimental API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #1981:
URL: https://github.com/apache/polaris/pull/1981#issuecomment-3045931222
Please allow some more review time. From my POV the dev list discussion does not have a conclusion yet :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1981:
URL: https://github.com/apache/polaris/pull/1981#discussion_r2192954978
##########
delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.delegation.api;
+
+import jakarta.validation.Valid;
+import jakarta.validation.constraints.NotNull;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
+import org.apache.polaris.delegation.api.model.TaskExecutionRequest;
+import org.apache.polaris.delegation.api.model.TaskExecutionResponse;
+import org.apache.polaris.delegation.api.model.TaskType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * REST API for the Polaris Delegation Service.
+ *
+ * <p>Provides endpoints for submitting long-running tasks for synchronous execution. This API
+ * allows the main Polaris catalog to offload resource-intensive operations to maintain low-latency
+ * performance.
+ *
+ * <p><strong>Note:</strong> This is the initial API framework implementation. The actual task
+ * execution logic will be implemented in future development phases.
+ */
+@Path("/api/v1/tasks/execute")
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+public class DelegationApi {
Review Comment:
Can we add `@experimental` here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1981:
URL: https://github.com/apache/polaris/pull/1981#discussion_r2192985883
##########
delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.delegation.api;
+
+import jakarta.validation.Valid;
+import jakarta.validation.constraints.NotNull;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
+import org.apache.polaris.delegation.api.model.TaskExecutionRequest;
+import org.apache.polaris.delegation.api.model.TaskExecutionResponse;
+import org.apache.polaris.delegation.api.model.TaskType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * REST API for the Polaris Delegation Service.
+ *
+ * <p>Provides endpoints for submitting long-running tasks for synchronous execution. This API
+ * allows the main Polaris catalog to offload resource-intensive operations to maintain low-latency
+ * performance.
+ *
+ * <p><strong>Note:</strong> This is the initial API framework implementation. The actual task
+ * execution logic will be implemented in future development phases.
+ */
+@Path("/api/v1/tasks/execute")
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+public class DelegationApi {
Review Comment:
My proposal was more to "flag" it experimental (from code perspective). If the "whole" service is experimental, I'm fine with that.
Maybe a couple of tests to illustrate how it works would be welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1981:
URL: https://github.com/apache/polaris/pull/1981#issuecomment-3169654478
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on PR #1981:
URL: https://github.com/apache/polaris/pull/1981#issuecomment-3049626190
Hey @dimas-b, is there a particular thread on the ML you're looking to close? The most recent message from you just says `I'll certainly have a deeper look later` but that was a couple of weeks ago. I don't see a message from @snazy, who -1'd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Delegation Service Module and REST Framework [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1981:
URL: https://github.com/apache/polaris/pull/1981#discussion_r2193004598
##########
delegation-service/src/main/java/org/apache/polaris/delegation/api/DelegationApi.java:
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.polaris.delegation.api;
+
+import jakarta.validation.Valid;
+import jakarta.validation.constraints.NotNull;
+import jakarta.ws.rs.Consumes;
+import jakarta.ws.rs.POST;
+import jakarta.ws.rs.Path;
+import jakarta.ws.rs.Produces;
+import jakarta.ws.rs.core.MediaType;
+import jakarta.ws.rs.core.Response;
+import org.apache.polaris.delegation.api.model.TaskExecutionRequest;
+import org.apache.polaris.delegation.api.model.TaskExecutionResponse;
+import org.apache.polaris.delegation.api.model.TaskType;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * REST API for the Polaris Delegation Service.
+ *
+ * <p>Provides endpoints for submitting long-running tasks for synchronous execution. This API
+ * allows the main Polaris catalog to offload resource-intensive operations to maintain low-latency
+ * performance.
+ *
+ * <p><strong>Note:</strong> This is the initial API framework implementation. The actual task
+ * execution logic will be implemented in future development phases.
+ */
+@Path("/api/v1/tasks/execute")
+@Consumes(MediaType.APPLICATION_JSON)
+@Produces(MediaType.APPLICATION_JSON)
+public class DelegationApi {
Review Comment:
From reading the proposal, I think what will actually be experimental will be the `RemoteTaskExecutor` within Polaris, but that's not implemented in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create Delegation Service Module [polaris]
Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun commented on PR #1981:
URL: https://github.com/apache/polaris/pull/1981#issuecomment-3020594811
cc: @eric-maynard, @flyrain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org