You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2014/03/27 21:29:42 UTC

Review Request 19750: Fix for SQOOP-1209: Use _V_TABLE for querying the validity of a table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19750/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1209
    https://issues.apache.org/jira/browse/SQOOP-1209


Repository: sqoop-trunk


Description
-------

I modified the QUERY_CHECK_DITIONARY_FOR_TABLE to use _V_TABLE instead of _V_OBJECTS as it seems on some Netezza systems, the object type can be in lower case and fail the match

I could not reproduce the reported bug both with  6.0.8 [Build 24922] and 7.0 [Build 25936], but I made sure that the new dictionary query runs with those versions


Diffs
-----

  src/java/org/apache/sqoop/manager/DirectNetezzaManager.java 89deceb 

Diff: https://reviews.apache.org/r/19750/diff/


Testing
-------

Ran direct mode tests with NZ versions  6.0.8 [Build 24922] and 7.0 [Build 25936] 


Thanks,

Venkat Ranganathan


Re: Review Request 19750: Fix for SQOOP-1209: Use _V_TABLE for querying the validity of a table

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19750/#review38990
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On March 27, 2014, 8:29 p.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19750/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 8:29 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1209
>     https://issues.apache.org/jira/browse/SQOOP-1209
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I modified the QUERY_CHECK_DITIONARY_FOR_TABLE to use _V_TABLE instead of _V_OBJECTS as it seems on some Netezza systems, the object type can be in lower case and fail the match
> 
> I could not reproduce the reported bug both with  6.0.8 [Build 24922] and 7.0 [Build 25936], but I made sure that the new dictionary query runs with those versions
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/DirectNetezzaManager.java 89deceb 
> 
> Diff: https://reviews.apache.org/r/19750/diff/
> 
> 
> Testing
> -------
> 
> Ran direct mode tests with NZ versions  6.0.8 [Build 24922] and 7.0 [Build 25936] 
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>