[GitHub] yunxiyi commented on a change in pull request #2053: bugfix init reference dead lock

[GitBox <gi...@apache.org>]

yunxiyi commented on a change in pull request #2053: bugfix init reference dead lock 
URL: https://github.com/apache/incubator-dubbo/pull/2053#discussion_r201611201
 
 

 ##########
 File path: dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/extension/SpringExtensionFactory.java
 ##########
 @@ -51,6 +53,16 @@ public static void clearContexts() {
     @Override
     @SuppressWarnings("unchecked")
     public <T> T getExtension(Class<T> type, String name) {
+
+        //SPI never get from spring bean factory
+        if (type.isInterface() && type.isAnnotationPresent(SPI.class)) {
+            ExtensionLoader<T> loader = ExtensionLoader.getExtensionLoader(type);
 
 Review comment:
   you are right, it's not SpringExtensionFactory's duty to find SPI instance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org