[GitHub] calumleslie commented on issue #8887: Remove finalizers from Scala API

[GitBox <gi...@apache.org>]

calumleslie commented on issue #8887: Remove finalizers from Scala API
URL: https://github.com/apache/incubator-mxnet/pull/8887#issuecomment-348904168
 
 
   @marcoabreu 
   
   > Couldn't you create a class specifically for this test and introduce an obvious resource leak to check whether this is getting picked up?
   
   The issue is that we're testing a side-effect which isn't easily observable (a log line) and the toggle is held in a `lazy val` we can't change at runtime. As such we'd need to parameterise the code in order to test it, which is what would be intrusive. I'll have a wee go of this, I'm probably over-thinking it. :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services