You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Gayan Gunarathne <ga...@wso2.com> on 2015/11/30 07:02:13 UTC
Two different naming conventions for CEP 300 and CEP 301
I found the $subject for CEP300[1] and CEP301[2]. What is the ration behind
that or is that a mistake?
[1]
https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
[2]
https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
Thanks,
Gayan
--
Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Thanuja Uruththirakodeeswaran <th...@wso2.com>.
Hi Akila,
I have added a unit test called ThriftStatisticsPublisherTest in the same
p/r.
Thanks.
On Mon, Nov 30, 2015 at 1:57 PM, Akila Ravihansa Perera <ra...@wso2.com>
wrote:
> Hi Thanuja,
>
> I've added more comments, please check. Could you write a simple unit test
> to assert whether dataPublisherHolders and receiverGroups objects are
> populated correctly?
>
> Thanks.
>
> On Mon, Nov 30, 2015 at 1:44 PM, Thanuja Uruththirakodeeswaran <
> thanujau@wso2.com> wrote:
>
>> Please review and merge this p/r [1].
>>
>> [1]. https://github.com/apache/stratos/pull/496
>>
>> Thanks.
>>
>> On Mon, Nov 30, 2015 at 1:38 PM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>>
>>>
>>> On Mon, Nov 30, 2015 at 1:33 PM, Thanuja Uruththirakodeeswaran <
>>> thanujau@wso2.com> wrote:
>>>
>>>> Fixed it with commit [1].
>>>>
>>>> [1].
>>>> https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
>>>>
>>>
>>> Great. Could you please send a PR for this?
>>>
>>> Thanks,
>>> Gayan
>>>
>>>>
>>>> On Mon, Nov 30, 2015 at 12:32 PM, Akila Ravihansa Perera <
>>>> ravihansa@wso2.com> wrote:
>>>>
>>>>> IMO, it should be "cep310" (instead of "cep.310")
>>>>>
>>>>> On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> /s/cep301/cep310
>>>>>>
>>>>>> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>>>>>>> behind that or is that a mistake?
>>>>>>>
>>>>>>> [1]
>>>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
>>>>>>> [2]
>>>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Gayan
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Gayan Gunarathne
>>>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>> email : gayang@wso2.com | mobile : +94 775030545
>>>>>>> <%2B94%20766819985>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>>> Committer & PMC Member, Apache Stratos
>>>>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Akila Ravihansa Perera
>>>>> WSO2 Inc.; http://wso2.com/
>>>>>
>>>>> Blog: http://ravihansa3000.blogspot.com
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Thanuja Uruththirakodeeswaran
>>>> Software Engineer
>>>> WSO2 Inc.;http://wso2.com
>>>> lean.enterprise.middleware
>>>>
>>>> mobile: +94 774363167
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Gayan Gunarathne
>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>> Committer & PMC Member, Apache Stratos
>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>
>>>
>>>
>>
>>
>>
>> --
>> Thanuja Uruththirakodeeswaran
>> Software Engineer
>> WSO2 Inc.;http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: +94 774363167
>>
>
>
>
> --
> Akila Ravihansa Perera
> WSO2 Inc.; http://wso2.com/
>
> Blog: http://ravihansa3000.blogspot.com
>
--
Thanuja Uruththirakodeeswaran
Software Engineer
WSO2 Inc.;http://wso2.com
lean.enterprise.middleware
mobile: +94 774363167
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Akila Ravihansa Perera <ra...@wso2.com>.
Hi Thanuja,
I've added more comments, please check. Could you write a simple unit test
to assert whether dataPublisherHolders and receiverGroups objects are
populated correctly?
Thanks.
On Mon, Nov 30, 2015 at 1:44 PM, Thanuja Uruththirakodeeswaran <
thanujau@wso2.com> wrote:
> Please review and merge this p/r [1].
>
> [1]. https://github.com/apache/stratos/pull/496
>
> Thanks.
>
> On Mon, Nov 30, 2015 at 1:38 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>>
>>
>> On Mon, Nov 30, 2015 at 1:33 PM, Thanuja Uruththirakodeeswaran <
>> thanujau@wso2.com> wrote:
>>
>>> Fixed it with commit [1].
>>>
>>> [1].
>>> https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
>>>
>>
>> Great. Could you please send a PR for this?
>>
>> Thanks,
>> Gayan
>>
>>>
>>> On Mon, Nov 30, 2015 at 12:32 PM, Akila Ravihansa Perera <
>>> ravihansa@wso2.com> wrote:
>>>
>>>> IMO, it should be "cep310" (instead of "cep.310")
>>>>
>>>> On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> /s/cep301/cep310
>>>>>
>>>>> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com>
>>>>> wrote:
>>>>>
>>>>>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>>>>>> behind that or is that a mistake?
>>>>>>
>>>>>> [1]
>>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
>>>>>> [2]
>>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Gayan
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Gayan Gunarathne
>>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>>> Committer & PMC Member, Apache Stratos
>>>>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>> Committer & PMC Member, Apache Stratos
>>>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Akila Ravihansa Perera
>>>> WSO2 Inc.; http://wso2.com/
>>>>
>>>> Blog: http://ravihansa3000.blogspot.com
>>>>
>>>
>>>
>>>
>>> --
>>> Thanuja Uruththirakodeeswaran
>>> Software Engineer
>>> WSO2 Inc.;http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> mobile: +94 774363167
>>>
>>
>>
>>
>> --
>>
>> Gayan Gunarathne
>> Technical Lead, WSO2 Inc. (http://wso2.com)
>> Committer & PMC Member, Apache Stratos
>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>
>>
>>
>
>
>
> --
> Thanuja Uruththirakodeeswaran
> Software Engineer
> WSO2 Inc.;http://wso2.com
> lean.enterprise.middleware
>
> mobile: +94 774363167
>
--
Akila Ravihansa Perera
WSO2 Inc.; http://wso2.com/
Blog: http://ravihansa3000.blogspot.com
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Thanuja Uruththirakodeeswaran <th...@wso2.com>.
Please review and merge this p/r [1].
[1]. https://github.com/apache/stratos/pull/496
Thanks.
On Mon, Nov 30, 2015 at 1:38 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
>
>
> On Mon, Nov 30, 2015 at 1:33 PM, Thanuja Uruththirakodeeswaran <
> thanujau@wso2.com> wrote:
>
>> Fixed it with commit [1].
>>
>> [1].
>> https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
>>
>
> Great. Could you please send a PR for this?
>
> Thanks,
> Gayan
>
>>
>> On Mon, Nov 30, 2015 at 12:32 PM, Akila Ravihansa Perera <
>> ravihansa@wso2.com> wrote:
>>
>>> IMO, it should be "cep310" (instead of "cep.310")
>>>
>>> On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> /s/cep301/cep310
>>>>
>>>> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>>>>> behind that or is that a mistake?
>>>>>
>>>>> [1]
>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
>>>>> [2]
>>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>> --
>>>>>
>>>>> Gayan Gunarathne
>>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>>> Committer & PMC Member, Apache Stratos
>>>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>> Committer & PMC Member, Apache Stratos
>>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Akila Ravihansa Perera
>>> WSO2 Inc.; http://wso2.com/
>>>
>>> Blog: http://ravihansa3000.blogspot.com
>>>
>>
>>
>>
>> --
>> Thanuja Uruththirakodeeswaran
>> Software Engineer
>> WSO2 Inc.;http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: +94 774363167
>>
>
>
>
> --
>
> Gayan Gunarathne
> Technical Lead, WSO2 Inc. (http://wso2.com)
> Committer & PMC Member, Apache Stratos
> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>
>
>
--
Thanuja Uruththirakodeeswaran
Software Engineer
WSO2 Inc.;http://wso2.com
lean.enterprise.middleware
mobile: +94 774363167
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Gayan Gunarathne <ga...@wso2.com>.
On Mon, Nov 30, 2015 at 1:33 PM, Thanuja Uruththirakodeeswaran <
thanujau@wso2.com> wrote:
> Fixed it with commit [1].
>
> [1].
> https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
>
Great. Could you please send a PR for this?
Thanks,
Gayan
>
> On Mon, Nov 30, 2015 at 12:32 PM, Akila Ravihansa Perera <
> ravihansa@wso2.com> wrote:
>
>> IMO, it should be "cep310" (instead of "cep.310")
>>
>> On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> /s/cep301/cep310
>>>
>>> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com>
>>> wrote:
>>>
>>>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>>>> behind that or is that a mistake?
>>>>
>>>> [1]
>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
>>>> [2]
>>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>>>>
>>>>
>>>> Thanks,
>>>> Gayan
>>>>
>>>> --
>>>>
>>>> Gayan Gunarathne
>>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>>> Committer & PMC Member, Apache Stratos
>>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Gayan Gunarathne
>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>> Committer & PMC Member, Apache Stratos
>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>
>>>
>>>
>>
>>
>>
>> --
>> Akila Ravihansa Perera
>> WSO2 Inc.; http://wso2.com/
>>
>> Blog: http://ravihansa3000.blogspot.com
>>
>
>
>
> --
> Thanuja Uruththirakodeeswaran
> Software Engineer
> WSO2 Inc.;http://wso2.com
> lean.enterprise.middleware
>
> mobile: +94 774363167
>
--
Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Thanuja Uruththirakodeeswaran <th...@wso2.com>.
Fixed it with commit [1].
[1].
https://github.com/Thanu/stratos/commit/c5df03d3e6a8bab930518f69baa62aae88a5bcbe
On Mon, Nov 30, 2015 at 12:32 PM, Akila Ravihansa Perera <ravihansa@wso2.com
> wrote:
> IMO, it should be "cep310" (instead of "cep.310")
>
> On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne <ga...@wso2.com>
> wrote:
>
>> /s/cep301/cep310
>>
>> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com>
>> wrote:
>>
>>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>>> behind that or is that a mistake?
>>>
>>> [1]
>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
>>> [2]
>>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>>>
>>>
>>> Thanks,
>>> Gayan
>>>
>>> --
>>>
>>> Gayan Gunarathne
>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>> Committer & PMC Member, Apache Stratos
>>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>>
>>>
>>>
>>
>>
>>
>> --
>>
>> Gayan Gunarathne
>> Technical Lead, WSO2 Inc. (http://wso2.com)
>> Committer & PMC Member, Apache Stratos
>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>
>>
>>
>
>
>
> --
> Akila Ravihansa Perera
> WSO2 Inc.; http://wso2.com/
>
> Blog: http://ravihansa3000.blogspot.com
>
--
Thanuja Uruththirakodeeswaran
Software Engineer
WSO2 Inc.;http://wso2.com
lean.enterprise.middleware
mobile: +94 774363167
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Akila Ravihansa Perera <ra...@wso2.com>.
IMO, it should be "cep310" (instead of "cep.310")
On Mon, Nov 30, 2015 at 11:36 AM, Gayan Gunarathne <ga...@wso2.com> wrote:
> /s/cep301/cep310
>
> On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com>
> wrote:
>
>> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
>> behind that or is that a mistake?
>>
>> [1]
>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
>> [2]
>> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>>
>>
>> Thanks,
>> Gayan
>>
>> --
>>
>> Gayan Gunarathne
>> Technical Lead, WSO2 Inc. (http://wso2.com)
>> Committer & PMC Member, Apache Stratos
>> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>>
>>
>>
>
>
>
> --
>
> Gayan Gunarathne
> Technical Lead, WSO2 Inc. (http://wso2.com)
> Committer & PMC Member, Apache Stratos
> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>
>
>
--
Akila Ravihansa Perera
WSO2 Inc.; http://wso2.com/
Blog: http://ravihansa3000.blogspot.com
Re: Two different naming conventions for CEP 300 and CEP 301
Posted by Gayan Gunarathne <ga...@wso2.com>.
/s/cep301/cep310
On Mon, Nov 30, 2015 at 11:32 AM, Gayan Gunarathne <ga...@wso2.com> wrote:
> I found the $subject for CEP300[1] and CEP301[2]. What is the ration
> behind that or is that a mistake?
>
> [1]
> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.0.0/pom.xml#L30
> [2]
> https://github.com/apache/stratos/blob/stratos-4.1.x/extensions/cep/modules/stratos-cep-extension/wso2cep-3.1.0/pom.xml#L24
>
>
> Thanks,
> Gayan
>
> --
>
> Gayan Gunarathne
> Technical Lead, WSO2 Inc. (http://wso2.com)
> Committer & PMC Member, Apache Stratos
> email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
>
>
>
--
Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>