[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #882: Support DISK Command

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #882:
URL: https://github.com/apache/incubator-kvrocks/pull/882#discussion_r990209248


##########
src/redis_cmd.cc:
##########
@@ -3476,6 +3477,32 @@ class CommandInfo : public Commander {
   }
 };
 
+class CommandDisk : public Commander {
+ public:
+  Status Parse(const std::vector<std::string> &args) override {
+    std::string opname = Util::ToLower(args[1]);
+    if (opname != "usage")
+      return Status(Status::RedisInvalidCmd, "Unknown operation");
+    if (args.size() != 3)
+      return Status(Status::RedisInvalidCmd, "Incorrect number of parameters");

Review Comment:
   Can remove this since it's done before executing the command
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org