[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2312: Don't sort batches during plan

[GitBox <gi...@apache.org>]

alamb commented on code in PR #2312:
URL: https://github.com/apache/arrow-datafusion/pull/2312#discussion_r855474275


##########
datafusion/core/src/physical_plan/stream.rs:
##########
@@ -73,3 +74,45 @@ impl RecordBatchStream for RecordBatchReceiverStream {
         self.schema.clone()
     }
 }
+
+/// Combines a [`BoxStream`] with [`SchemaRef`] implementing
+/// [`RecordBatchStream`] for the combination

Review Comment:
   ```suggestion
   /// Combines a [`BoxStream`] (created by calling `boxed` on a stream that produced `RecordBatch`es) 
   /// with a [`SchemaRef`] implementing [`RecordBatchStream`] for the combination
   ```



##########
datafusion/core/src/physical_plan/stream.rs:
##########
@@ -73,3 +74,45 @@ impl RecordBatchStream for RecordBatchReceiverStream {
         self.schema.clone()
     }
 }
+
+/// Combines a [`BoxStream`] with [`SchemaRef`] implementing
+/// [`RecordBatchStream`] for the combination

Review Comment:
   I find the whole `boxed` stream concept somewhat confusing, so I am trying to leave hints around for my future self



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org