[GitHub] [netbeans] sdedic commented on a change in pull request #1092: Using Graal.js 19.0.0 in platform/core.network

[GitBox <gi...@apache.org>]

sdedic commented on a change in pull request #1092: Using Graal.js 19.0.0 in platform/core.network
URL: https://github.com/apache/netbeans/pull/1092#discussion_r288079479
 
 

 ##########
 File path: ide/libs.graalsdk/src/org/netbeans/libs/graalsdk/impl/GraalContext.java
 ##########
 @@ -29,16 +29,34 @@
 import javax.script.ScriptContext;
 import javax.script.SimpleBindings;
 import org.graalvm.polyglot.Context;
+import org.graalvm.polyglot.HostAccess;
+import org.graalvm.polyglot.PolyglotAccess;
 import org.openide.util.io.ReaderInputStream;
 
 final class GraalContext implements ScriptContext {
+    private final static String ALLOW_ALL_ACCESS = "allowAllAccess"; // NOI18N
 
 Review comment:
   Isn't this value a part of API - if so, it should move to `GraalSDK` so API users can depend on a symbol. If this library impl reads some property defined by Scripting API, shouldn't be the string in Scripting API/SPI ?
   
   ... maybe an overkill.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists