You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2026/06/14 18:18:46 UTC
[PR] [SPARK-57444][INFRA] Document versioning and branch policy in AGENTS.md [spark]
cloud-fan opened a new pull request, #56504:
URL: https://github.com/apache/spark/pull/56504
### What changes were proposed in this pull request?
Adds a "Versioning and Branch Policy" section to `AGENTS.md` so coding agents pick the correct target version for a PR (used for `@since` annotations, config `.version("...")` entries, new `MimaExcludes` sections, etc.).
The documented policy:
- Most PRs merge to **both** `master` and the latest rolling maintenance branch `branch-<N>.x`; only breaking / binary-incompatible changes and non-critical dependency upgrades go to `master` only.
- Therefore a change's first release version comes from `branch-<N>.x`, **not** from `master` -- deriving it from `master`'s `-SNAPSHOT` alone is the common mistake.
- How to determine the version (decide target branches, then take the oldest branch the change lands on with `-SNAPSHOT` stripped), plus the commands to find the latest maintenance branch and its version.
### Why are the changes needed?
`AGENTS.md` guides coding agents working in this repo. Without this, an agent reading only `master` (currently `5.0.0-SNAPSHOT`) would label a normally-backported change `@since 5.0.0`, when it actually ships first in the `branch-4.x` release (`4.3.0`).
### Does this PR introduce _any_ user-facing change?
No (documentation for coding agents only).
### How was this patch tested?
N/A (documentation only).
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8)
This pull request and its description were written by Isaac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57444][INFRA] Document versioning and branch policy in AGENTS.md and add dev/next_version_candidates.py [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #56504: [SPARK-57444][INFRA] Document versioning and branch policy in AGENTS.md and add dev/next_version_candidates.py
URL: https://github.com/apache/spark/pull/56504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57444][INFRA] Document versioning and branch policy in AGENTS.md [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #56504:
URL: https://github.com/apache/spark/pull/56504#discussion_r3410081690
##########
AGENTS.md:
##########
@@ -156,6 +156,27 @@ DO NOT force push or use `--amend` on pushed commits unless the user explicitly
Always get user approval before external operations such as pushing commits, creating PRs, or posting comments. Use `gh pr create` to open PRs. If `gh` is not installed, generate the GitHub PR URL for the user and recommend installing the GitHub CLI.
+## Versioning and Branch Policy
+
+**If the PR is opened against a non-`master` base branch** (e.g. it targets `branch-4.x` directly), the target version is simply that base branch's version with `-SNAPSHOT` stripped — done; skip the rest of this section.
Review Comment:
According to the content, this PR is blocked by the following.
- https://github.com/apache/spark/pull/56503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57444][INFRA] Document versioning and branch policy in AGENTS.md [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #56504:
URL: https://github.com/apache/spark/pull/56504#issuecomment-4703322765
https://github.com/apache/spark/pull/56503 merged, this is ready to review. cc @HyukjinKwon @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-57444][INFRA] Document versioning and branch policy in AGENTS.md and add dev/next_version_candidates.py [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #56504:
URL: https://github.com/apache/spark/pull/56504#issuecomment-4712427334
thanks for review, merging to master/4.x!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org