You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/07/31 16:18:36 UTC
[GitHub] [rocketmq-externals] StyleTang opened a new pull request #769: [ISSUE #768] Console message trace compatibility
StyleTang opened a new pull request #769:
URL: https://github.com/apache/rocketmq-externals/pull/769
## What is the purpose of the change
make RocketMQ console message trace compatible with older version RocketMQ client
### Console message trace compatibility conclusion
* if have both subBefore and subAfter trace
* <=4.7.1 and > 4.9.0 endTimestamp use beginTimestamp + costTime
* 4.9.0 use real endTimestamp
* if subBefore is missing
* all version beginTimestamp and retryTime is missing
* <=4.7.1 and > 4.9.0 will lost endTimestamp and groupName **but 4.9.0 works well**
* if subAfter is missing
* all version endTimeStamp and status is missing
**Suggest add subAfter timestamp and groupName back to provide a better use experience.**
https://github.com/apache/rocketmq/pull/3137
## Brief changelog
* handle old version client subBefore trace missing case
* handle old version client subAfter trace missing case
* missing value use N/A instead of --
* consume message trace use beginTime + costTime if don't have endTimestamp
## Verifying this change
### 4.9.0 (Current Version) Test
#### Have Both subBefore and subAfter
#### subBefore missing
#### subAfter missing
### <=4.7.1 and > 4.9.0 (now develop branch) Test
#### Have Both subBefore and subAfter
#### subBefore missing
#### subAfter missing
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-externals] vongosling merged pull request #769: [ISSUE #768] Console message trace compatibility
Posted by GitBox <gi...@apache.org>.
vongosling merged pull request #769:
URL: https://github.com/apache/rocketmq-externals/pull/769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org