You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/06/13 23:17:58 UTC

[jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Also ensure that we close the InputStream.
You can merge this Pull Request by running:

  git pull https://github.com/andrewgaul/jclouds-labs-aws hashing-avoid-buffering

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-aws/pull/10

-- Commit Summary --

  * Avoid buffering entire input when hashing

-- File Changes --

    M glacier/src/main/java/org/jclouds/glacier/util/AWSRequestSignerV4.java (31)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-aws/pull/10.patch
https://github.com/jclouds/jclouds-labs-aws/pull/10.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10

Re: [jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-labs-aws #952](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/952/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10#issuecomment-46061508

Re: [jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Posted by Roman Coedo <no...@github.com>.

Yes, passing HashCode makes more sense.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10#issuecomment-46061702

Re: [jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Posted by Andrew Gaul <no...@github.com>.

Also @rcoedo what do you think about passing around `HashCode` instead of `String` for type-safety?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10#issuecomment-46061002

Re: [jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Posted by Andrew Gaul <no...@github.com>.

Pushed to master.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10#issuecomment-46249487

Re: [jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-labs-aws-pull-requests #20](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/20/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10#issuecomment-46061429

Re: [jclouds-labs-aws] Avoid buffering entire input when hashing (#10)

Posted by Andrew Gaul <no...@github.com>.

Closed #10.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/10#event-131963489