You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sébastien Brisard (JIRA)" <ji...@apache.org> on 2012/06/22 11:06:43 UTC
[jira] [Created] (MATH-807) Allow for the use of
Incrementor.MaxCountExceededCallback in IterationManager
Sébastien Brisard created MATH-807:
--------------------------------------
Summary: Allow for the use of Incrementor.MaxCountExceededCallback in IterationManager
Key: MATH-807
URL: https://issues.apache.org/jira/browse/MATH-807
Project: Commons Math
Issue Type: Improvement
Affects Versions: 3.1
Reporter: Sébastien Brisard
Assignee: Sébastien Brisard
Fix For: 3.0
{{IterationManager}} uses {{Incrementor}} for the iterations book-keeping. When the maximum number of iterations is reached, the default behavior is to throw a {{MaxCountExceededException}} unless a {{MaxCountExceededCallback}} was passed to the constructor of {{Incrementor}}.
In the current implementation of {{IterationManager}}, this feature is hidden. It is proposed to add a new constructor {{IterationManager(Incrementor)}}, which would permit the use of call-back methods through the use of appropriately initialized incrementors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-807) Allow for the use of
Incrementor.MaxCountExceededCallback in IterationManager
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sébastien Brisard resolved MATH-807.
------------------------------------
Resolution: Fixed
Fix Version/s: 3.1
Done in {{r1353141}}.
> Allow for the use of Incrementor.MaxCountExceededCallback in IterationManager
> -----------------------------------------------------------------------------
>
> Key: MATH-807
> URL: https://issues.apache.org/jira/browse/MATH-807
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Labels: iterative
> Fix For: 3.1, 3.0
>
>
> {{IterationManager}} uses {{Incrementor}} for the iterations book-keeping. When the maximum number of iterations is reached, the default behavior is to throw a {{MaxCountExceededException}} unless a {{MaxCountExceededCallback}} was passed to the constructor of {{Incrementor}}.
> In the current implementation of {{IterationManager}}, this feature is hidden. It is proposed to add a new constructor {{IterationManager(Incrementor)}}, which would permit the use of call-back methods through the use of appropriately initialized incrementors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-807) Allow for the use of
Incrementor.MaxCountExceededCallback in IterationManager
Posted by "Sébastien Brisard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399267#comment-13399267 ]
Sébastien Brisard commented on MATH-807:
----------------------------------------
You're right. Your proposal is safer.
> Allow for the use of Incrementor.MaxCountExceededCallback in IterationManager
> -----------------------------------------------------------------------------
>
> Key: MATH-807
> URL: https://issues.apache.org/jira/browse/MATH-807
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Labels: iterative
> Fix For: 3.0
>
>
> {{IterationManager}} uses {{Incrementor}} for the iterations book-keeping. When the maximum number of iterations is reached, the default behavior is to throw a {{MaxCountExceededException}} unless a {{MaxCountExceededCallback}} was passed to the constructor of {{Incrementor}}.
> In the current implementation of {{IterationManager}}, this feature is hidden. It is proposed to add a new constructor {{IterationManager(Incrementor)}}, which would permit the use of call-back methods through the use of appropriately initialized incrementors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-807) Allow for the use of
Incrementor.MaxCountExceededCallback in IterationManager
Posted by "Gilles (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399261#comment-13399261 ]
Gilles commented on MATH-807:
-----------------------------
Is it the callback which you want to be able to customize, or do you really want to let an external code fiddle with the counter?
If it's the former, it would be sufficient to have
{code}
public IterationManager(int maxIterations,
Incrementor.MaxCountExceededCallback cb) {
this.iterations = new Incrementor(maxIterations, cb);
// ...
}
{code}
> Allow for the use of Incrementor.MaxCountExceededCallback in IterationManager
> -----------------------------------------------------------------------------
>
> Key: MATH-807
> URL: https://issues.apache.org/jira/browse/MATH-807
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.1
> Reporter: Sébastien Brisard
> Assignee: Sébastien Brisard
> Labels: iterative
> Fix For: 3.0
>
>
> {{IterationManager}} uses {{Incrementor}} for the iterations book-keeping. When the maximum number of iterations is reached, the default behavior is to throw a {{MaxCountExceededException}} unless a {{MaxCountExceededCallback}} was passed to the constructor of {{Incrementor}}.
> In the current implementation of {{IterationManager}}, this feature is hidden. It is proposed to add a new constructor {{IterationManager(Incrementor)}}, which would permit the use of call-back methods through the use of appropriately initialized incrementors.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira