You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2019/11/21 22:01:20 UTC
svn commit: r1870121 - in /poi/trunk/src:
examples/src/org/apache/poi/poifs/poibrowser/
java/org/apache/poi/hssf/extractor/ java/org/apache/poi/hssf/model/
java/org/apache/poi/hssf/record/
java/org/apache/poi/hssf/record/pivottable/ java/org/apache/poi...
Author: fanningpj
Date: Thu Nov 21 22:01:20 2019
New Revision: 1870121
URL: http://svn.apache.org/viewvc?rev=1870121&view=rev
Log:
replace more StringBuffers
Modified:
poi/trunk/src/examples/src/org/apache/poi/poifs/poibrowser/PropertySetDescriptorRenderer.java
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java
poi/trunk/src/java/org/apache/poi/hssf/record/MergeCellsRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/pivottable/PageItemRecord.java
poi/trunk/src/java/org/apache/poi/hssf/usermodel/FontDetails.java
poi/trunk/src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java
poi/trunk/src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java
poi/trunk/src/java/org/apache/poi/ss/formula/constant/ErrorConstant.java
poi/trunk/src/java/org/apache/poi/util/HexRead.java
poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
poi/trunk/src/testcases/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java
Modified: poi/trunk/src/examples/src/org/apache/poi/poifs/poibrowser/PropertySetDescriptorRenderer.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/examples/src/org/apache/poi/poifs/poibrowser/PropertySetDescriptorRenderer.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/examples/src/org/apache/poi/poifs/poibrowser/PropertySetDescriptorRenderer.java (original)
+++ poi/trunk/src/examples/src/org/apache/poi/poifs/poibrowser/PropertySetDescriptorRenderer.java Thu Nov 21 22:01:20 2019
@@ -108,7 +108,7 @@ public class PropertySetDescriptorRender
*/
protected String sectionsToString(final List<Section> sections)
{
- final StringBuffer b = new StringBuffer();
+ final StringBuilder b = new StringBuilder();
int count = 1;
for (Iterator<Section> i = sections.iterator(); i.hasNext();)
{
@@ -129,7 +129,7 @@ public class PropertySetDescriptorRender
*/
protected String toString(final Section s, final String name)
{
- final StringBuffer b = new StringBuffer();
+ final StringBuilder b = new StringBuilder();
b.append("\n" + name + " Format ID: ");
b.append(HexDump.toHex(s.getFormatID().getBytes()));
b.append("\n" + name + " Offset: " + s.getOffset());
Modified: poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java Thu Nov 21 22:01:20 2019
@@ -162,7 +162,7 @@ public class EventBasedExcelExtractor ex
private SSTRecord sstRecord;
private final List<String> sheetNames;
- final StringBuffer _text = new StringBuffer();
+ final StringBuilder _text = new StringBuilder();
private int sheetNum = -1;
private int rowNum;
Modified: poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/model/InternalSheet.java Thu Nov 21 22:01:20 2019
@@ -553,7 +553,7 @@ public final class InternalSheet {
{
log.log(POILogger.DEBUG, "Sheet.setDimensions");
log.log(POILogger.DEBUG,
- (new StringBuffer("firstrow")).append(firstrow)
+ (new StringBuilder("firstrow")).append(firstrow)
.append("firstcol").append(firstcol).append("lastrow")
.append(lastrow).append("lastcol").append(lastcol)
.toString());
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/MergeCellsRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/MergeCellsRecord.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/MergeCellsRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/MergeCellsRecord.java Thu Nov 21 22:01:20 2019
@@ -90,7 +90,7 @@ public final class MergeCellsRecord exte
@Override
public String toString() {
- StringBuffer retval = new StringBuffer();
+ StringBuilder retval = new StringBuilder();
retval.append("[MERGEDCELLS]").append("\n");
retval.append(" .numregions =").append(getNumAreas()).append("\n");
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/pivottable/PageItemRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/pivottable/PageItemRecord.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/pivottable/PageItemRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/pivottable/PageItemRecord.java Thu Nov 21 22:01:20 2019
@@ -52,7 +52,7 @@ public final class PageItemRecord extend
out.writeShort(_idObj);
}
- public void appendDebugInfo(StringBuffer sb) {
+ public void appendDebugInfo(StringBuilder sb) {
sb.append('(');
sb.append( "isxvi=").append(HexDump.shortToHex(_isxvi));
sb.append(" isxvd=").append(HexDump.shortToHex(_isxvd));
@@ -97,7 +97,7 @@ public final class PageItemRecord extend
@Override
public String toString() {
- StringBuffer sb = new StringBuffer();
+ StringBuilder sb = new StringBuilder();
sb.append("[SXPI]\n");
for (int i = 0; i < _fieldInfos.length; i++) {
Modified: poi/trunk/src/java/org/apache/poi/hssf/usermodel/FontDetails.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/usermodel/FontDetails.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/usermodel/FontDetails.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/usermodel/FontDetails.java Thu Nov 21 22:01:20 2019
@@ -156,7 +156,7 @@ public class FontDetails
{
if(max != -1 && i == listSize - 1)
{
- StringBuffer buf = new StringBuffer((text.length() * (listSize - i)) / listSize);
+ StringBuilder buf = new StringBuilder((text.length() * (listSize - i)) / listSize);
while(tok.hasMoreTokens())
{
buf.append(tok.nextToken());
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/CellEvaluationFrame.java Thu Nov 21 22:01:20 2019
@@ -40,7 +40,7 @@ final class CellEvaluationFrame {
}
public String toString() {
- StringBuffer sb = new StringBuffer(64);
+ StringBuilder sb = new StringBuilder(64);
sb.append(getClass().getName()).append(" [");
sb.append("]");
return sb.toString();
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/FormulaUsedBlankCellSet.java Thu Nov 21 22:01:20 2019
@@ -158,7 +158,7 @@ final class FormulaUsedBlankCellSet {
}
@Override
public String toString() {
- StringBuffer sb = new StringBuffer(64);
+ StringBuilder sb = new StringBuilder(64);
CellReference crA = new CellReference(_firstRowIndex, _firstColumnIndex, false, false);
CellReference crB = new CellReference(_lastRowIndex, _lastColumnIndex, false, false);
sb.append(getClass().getName());
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/constant/ErrorConstant.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/constant/ErrorConstant.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/constant/ErrorConstant.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/constant/ErrorConstant.java Thu Nov 21 22:01:20 2019
@@ -71,7 +71,7 @@ public class ErrorConstant {
}
public String toString() {
- StringBuffer sb = new StringBuffer(64);
+ StringBuilder sb = new StringBuilder(64);
sb.append(getClass().getName()).append(" [");
sb.append(getText());
sb.append("]");
Modified: poi/trunk/src/java/org/apache/poi/util/HexRead.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/util/HexRead.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/util/HexRead.java (original)
+++ poi/trunk/src/java/org/apache/poi/util/HexRead.java Thu Nov 21 22:01:20 2019
@@ -55,7 +55,7 @@ public class HexRead {
*/
public static byte[] readData(InputStream stream, String section ) throws IOException {
try {
- StringBuffer sectionText = new StringBuffer();
+ StringBuilder sectionText = new StringBuilder();
boolean inSection = false;
int c = stream.read();
while ( c != -1 ) {
@@ -66,12 +66,12 @@ public class HexRead {
case '\n':
case '\r':
inSection = false;
- sectionText = new StringBuffer();
+ sectionText = new StringBuilder();
break;
case ']':
inSection = false;
if ( sectionText.toString().equals( section ) ) return readData( stream, '[' );
- sectionText = new StringBuffer();
+ sectionText = new StringBuilder();
break;
default:
if ( inSection ) sectionText.append( (char) c );
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hpbf/extractor/PublisherTextExtractor.java Thu Nov 21 22:01:20 2019
@@ -61,7 +61,7 @@ public final class PublisherTextExtracto
public String getText() {
- StringBuffer text = new StringBuffer();
+ StringBuilder text = new StringBuilder();
// Get the text from the Quill Contents
QCBit[] bits = doc.getQuillContents().getBits();
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/StyleTextPropAtom.java Thu Nov 21 22:01:20 2019
@@ -369,13 +369,11 @@ public final class StyleTextPropAtom ext
/**
- * Dump the record content into <code>StringBuffer</code>
- *
* @return the string representation of the record data
*/
@Override
public String toString(){
- StringBuffer out = new StringBuffer();
+ StringBuilder out = new StringBuilder();
out.append("StyleTextPropAtom:\n");
if (!initialised) {
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java Thu Nov 21 22:01:20 2019
@@ -359,16 +359,6 @@ public final class TestBugs extends Base
assertEquals(a.getRichStringCellValue().getString(), b.getRichStringCellValue().getString());
}
- /*private static String unicodeString(HSSFCell cell) {
- String ss = cell.getRichStringCellValue().getString();
- char s[] = ss.toCharArray();
- StringBuffer sb = new StringBuffer();
- for (int x=0;x<s.length;x++) {
- sb.append("\\u").append(Integer.toHexString(s[x]));
- }
- return sb.toString();
- }*/
-
/**
* Error in opening wb
*/
Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java?rev=1870121&r1=1870120&r2=1870121&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/formula/function/ExcelFileFormatDocFunctionExtractor.java Thu Nov 21 22:01:20 2019
@@ -111,7 +111,7 @@ public final class ExcelFileFormatDocFun
_isVolatile = isVolatile;
}
private static String convertSpecialChars(String ss) {
- StringBuffer sb = new StringBuffer(ss.length() + 4);
+ StringBuilder sb = new StringBuilder(ss.length() + 4);
for(int i=0; i<ss.length(); i++) {
char c = ss.charAt(i);
if (isSimpleAscii(c)) {
@@ -256,7 +256,7 @@ public final class ExcelFileFormatDocFun
private boolean _isInsideTable;
private final List<String> _rowData;
- private final StringBuffer _textNodeBuffer;
+ private final StringBuilder _textNodeBuffer;
private final List<Boolean> _rowNoteFlags;
private boolean _cellHasNote;
@@ -268,7 +268,7 @@ public final class ExcelFileFormatDocFun
_elemNameStack = new Stack<>();
_isInsideTable = false;
_rowData = new ArrayList<>();
- _textNodeBuffer = new StringBuffer();
+ _textNodeBuffer = new StringBuilder();
_rowNoteFlags = new ArrayList<>();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org