You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:20:49 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #890: ORC-965: Fix ZSTD 'Overflow detected' failure

dongjoon-hyun commented on a change in pull request #890:
URL: https://github.com/apache/orc/pull/890#discussion_r699602594



##########
File path: java/core/src/test/org/apache/orc/TestVectorOrcFile.java
##########
@@ -2281,7 +2281,7 @@ public void testZstd(Version fileFormat) throws Exception {
         OrcFile.writerOptions(conf)
             .setSchema(schema)
             .compress(CompressionKind.ZSTD)
-            .bufferSize(2000)
+            .bufferSize(1000)

Review comment:
       With aircompressor 0.19/0.20, this raises `Overflow detected` error.
   ```
   Caused by: java.lang.IllegalStateException: Overflow detected
   	at io.airlift.compress.zstd.Util.checkState(Util.java:59)
   	at io.airlift.compress.zstd.BitOutputStream.close(BitOutputStream.java:85)
   	at io.airlift.compress.zstd.HuffmanCompressor.compressSingleStream(HuffmanCompressor.java:130)
   	at io.airlift.compress.zstd.HuffmanCompressor.compress4streams(HuffmanCompressor.java:75)
   ```

##########
File path: java/core/src/test/org/apache/orc/TestVectorOrcFile.java
##########
@@ -2281,7 +2281,7 @@ public void testZstd(Version fileFormat) throws Exception {
         OrcFile.writerOptions(conf)
             .setSchema(schema)
             .compress(CompressionKind.ZSTD)
-            .bufferSize(2000)
+            .bufferSize(1000)

Review comment:
       With aircompressor 0.19/0.20, this causes `Overflow detected` errors.
   ```
   Caused by: java.lang.IllegalStateException: Overflow detected
   	at io.airlift.compress.zstd.Util.checkState(Util.java:59)
   	at io.airlift.compress.zstd.BitOutputStream.close(BitOutputStream.java:85)
   	at io.airlift.compress.zstd.HuffmanCompressor.compressSingleStream(HuffmanCompressor.java:130)
   	at io.airlift.compress.zstd.HuffmanCompressor.compress4streams(HuffmanCompressor.java:75)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org