You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by no...@apache.org on 2020/12/29 12:48:01 UTC

[buildstream] 08/16: _variables.pyx: Fixed provenance from Variables.subst()

This is an automated email from the ASF dual-hosted git repository.

not-in-ldap pushed a commit to branch tristan/variables-refactor
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 30478ad6b22e626736308c99bbf9e254e42b5eff
Author: Tristan van Berkom <tr...@codethink.co.uk>
AuthorDate: Fri Jul 17 17:18:14 2020 +0900

    _variables.pyx: Fixed provenance from Variables.subst()
    
    Report provenance of the input ScalarNode when it refers to an
    undefined variable.
---
 src/buildstream/_variables.pyx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/buildstream/_variables.pyx b/src/buildstream/_variables.pyx
index 9dd4102..433b328 100644
--- a/src/buildstream/_variables.pyx
+++ b/src/buildstream/_variables.pyx
@@ -197,7 +197,8 @@ cdef class Variables:
                     unmatched.append(var)
 
             if unmatched:
-                message = "Unresolved variable{}: {}".format(
+                message = "{}: Unresolved variable{}: {}".format(
+                    node.get_provenance(),
                     "s" if len(unmatched) > 1 else "",
                     ", ".join(unmatched)
                 )