[GitHub] [yunikorn-core] craigcondit commented on pull request #412: [YUNIKORN-1213] Configurable Health Checker Interval

[GitBox <gi...@apache.org>]

craigcondit commented on PR #412:
URL: https://github.com/apache/yunikorn-core/pull/412#issuecomment-1132971411

   > I have examined all the functions for metrics generation in the `HealthCheck` and they are all called locally from the `runOnce` routine and the call tree that stems there. Given this, we can probably leave the routines as-is and add log messages at the `Warn` level to indicate that health metric reporting is disabled.
   
   Let's not log anything if the reporting is disabled -- if it is, that's a conscious decision on the admin's part so let's not punish him by spamming the logs.
    
   > There are also two methods that are exported and only ever called locally and I wonder if we can switch them to not be exported?
   > 
   > https://github.com/apache/yunikorn-core/blob/aacdb887fb5ff02441d5c577d23698086d711f28/pkg/scheduler/health_checker.go#L129
   > 
   > 
   > https://github.com/apache/yunikorn-core/blob/aacdb887fb5ff02441d5c577d23698086d711f28/pkg/scheduler/health_checker.go#L146
   
   Making these private should be fine.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org