[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4312: [Improve][Connector-V2][SelectDB Cloud]Refactor some SelectDB Cloud Sink code as well as support copy into batch and async flush and cdc

["TyrantLucifer (via GitHub)" <gi...@apache.org>]

TyrantLucifer commented on code in PR #4312:
URL: https://github.com/apache/incubator-seatunnel/pull/4312#discussion_r1130553380


##########
seatunnel-connectors-v2/connector-selectdb-cloud/src/main/java/org/apache/seatunnel/connectors/selectdb/exception/SelectDBConnectorErrorCode.java:
##########
@@ -15,19 +15,13 @@
  * limitations under the License.
  */
 
-package org.apache.seatunnel.connector.selectdb.exception;
+package org.apache.seatunnel.connectors.selectdb.exception;
 
 import org.apache.seatunnel.common.exception.SeaTunnelErrorCode;
 
 public enum SelectDBConnectorErrorCode implements SeaTunnelErrorCode {
-    UPLOAD_FAILED("SelectDB-01", "upload file error"),

Review Comment:
   Need update https://seatunnel.apache.org/docs/connector-v2/Error-Quick-Reference-Manual#starrocks-connector-error-codes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org