You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/13 21:58:00 UTC

[GitHub] jmeter pull request #360: Reordered menus. With some drive-by tidying up.

GitHub user ham1 opened a pull request:

    https://github.com/apache/jmeter/pull/360

    Reordered menus. With some drive-by tidying up.

    ## Description
    
    Added ability for MenuFactory to add separators to menus.
    Some TestBeanGUI refactoring for reformatting.
    New Spock test.
    Refactored AbstractThreadGroupGui menu creation.
    Cleaned up horrible if sequence and unneeded variables
    
    ## How Has This Been Tested?
    `ant test` and manually
    
    ## Screenshots (if appropriate):
    
    ![test-plan_menu](https://user-images.githubusercontent.com/3393038/33964457-6dbbb87c-e050-11e7-816c-c409da44fcc5.png)
    ![thread](https://user-images.githubusercontent.com/3393038/33964458-6ddc6f4a-e050-11e7-9f49-06168c5ba20b.png)
    ![sampler](https://user-images.githubusercontent.com/3393038/33964456-6d943dce-e050-11e7-9e10-6b6cfe200fbc.png)
    
    ## Types of changes
    - Bug fix (non-breaking change which fixes an issue)
    
    ## Checklist:
    <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
    - [x] My code follows the [code style][style-guide] of this project.
    - [x] I have updated the documentation accordingly.
    
    [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ham1/jmeter menu_sort_order

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/360.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #360
    
----
commit fc7e50fd28cde7760d0bc581f3513823abb0b2f3
Author: Graham Russell <gr...@ham1.co.uk>
Date:   2017-12-13T21:43:51Z

    Reordered menus. With some drive-by tidying up.
    Added ability for MenuFactory to add separators to menus.
    Some TestBeanGUI refactoring for reformatting.
    New Spock test.
    Refactored AbstractThreadGroupGui menu creation.
    Cleaned up horrible if sequence and unneeded variables

----


---

[GitHub] jmeter pull request #360: Reordered menus.

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/360


---

[GitHub] jmeter issue #360: Reordered menus.

Posted by codecov-io <gi...@git.apache.org>.

Github user codecov-io commented on the issue:

    https://github.com/apache/jmeter/pull/360
  
    # [Codecov](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=h1) Report
    > Merging [#360](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr&el=desc) will **increase** coverage by `0.01%`.
    > The diff coverage is `12.4%`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/jmeter/pull/360/graphs/tree.svg?height=150&width=650&token=6Q7CI1wFSh&src=pr)](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=tree)
    
    ```diff
    @@             Coverage Diff              @@
    ##              trunk     #360      +/-   ##
    ============================================
    + Coverage     58.19%   58.21%   +0.01%     
      Complexity    10210    10210              
    ============================================
      Files          1161     1162       +1     
      Lines         74189    74160      -29     
      Branches       7322     7302      -20     
    ============================================
    - Hits          43174    43169       -5     
    + Misses        28517    28492      -25     
    - Partials       2498     2499       +1
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
    |---|---|---|---|
    | [...apache/jmeter/extractor/gui/RegexExtractorGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL2d1aS9SZWdleEV4dHJhY3Rvckd1aS5qYXZh) | `89.79% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
    | [.../apache/jmeter/extractor/gui/HtmlExtractorGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL2d1aS9IdG1sRXh0cmFjdG9yR3VpLmphdmE=) | `85.59% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
    | [...rg/apache/jmeter/assertions/ResponseAssertion.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9SZXNwb25zZUFzc2VydGlvbi5qYXZh) | `78.22% <ø> (ø)` | `83 <0> (ø)` | :arrow_down: |
    | [...r/protocol/http/control/gui/HttpTestSampleGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL2d1aS9IdHRwVGVzdFNhbXBsZUd1aS5qYXZh) | `85.71% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
    | [.../org/apache/jmeter/assertions/JSR223Assertion.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9KU1IyMjNBc3NlcnRpb24uamF2YQ==) | `65% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
    | [...pache/jmeter/timers/gui/UniformRandomTimerGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdGltZXJzL2d1aS9Vbmlmb3JtUmFuZG9tVGltZXJHdWkuamF2YQ==) | `100% <ø> (ø)` | `7 <0> (ø)` | :arrow_down: |
    | [...nts/org/apache/jmeter/extractor/JoddExtractor.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0pvZGRFeHRyYWN0b3IuamF2YQ==) | `80.76% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
    | [...eter/protocol/http/config/gui/HttpDefaultsGui.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb25maWcvZ3VpL0h0dHBEZWZhdWx0c0d1aS5qYXZh) | `80.78% <ø> (ø)` | `21 <0> (ø)` | :arrow_down: |
    | [...s/org/apache/jmeter/visualizers/SummaryReport.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvU3VtbWFyeVJlcG9ydC5qYXZh) | `72.16% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
    | [...ts/org/apache/jmeter/extractor/JSoupExtractor.java](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0pTb3VwRXh0cmFjdG9yLmphdmE=) | `84.21% <ø> (ø)` | `8 <0> (ø)` | :arrow_down: |
    | ... and [26 more](https://codecov.io/gh/apache/jmeter/pull/360/diff?src=pr&el=tree-more) | |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=footer). Last update [427907f...fc7e50f](https://codecov.io/gh/apache/jmeter/pull/360?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---