[GitHub] [pulsar-helm-chart] MarvinCai commented on a diff in pull request #269: Support mechanism to provide external zookeeper-server list to build global/configuration zookeeper

[GitBox <gi...@apache.org>]

MarvinCai commented on code in PR #269:
URL: https://github.com/apache/pulsar-helm-chart/pull/269#discussion_r901590241


##########
charts/pulsar/templates/zookeeper-statefulset.yaml:
##########
@@ -134,10 +134,19 @@ spec:
           containerPort: {{ .Values.zookeeper.ports.clientTls }}
         {{- end }}
         env:
-        - name: ZOOKEEPER_SERVERS
-          value:
-            {{- $global := . }}
-            {{ range $i, $e := until (.Values.zookeeper.replicaCount | int) }}{{ if ne $i 0 }},{{ end }}{{ template "pulsar.fullname" $global }}-{{ $global.Values.zookeeper.component }}-{{ printf "%d" $i }}{{ end }}
+         - name: ZOOKEEPER_SERVERS
+        {{- if .Values.zookeeper.configData.ZOOKEEPER_SERVERS }}

Review Comment:
   probably add it to value file with an example and comment it out? so user can know how to use this feature.
   As from the script change, seems the provided server list need to contain election port and follower port.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org