You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "Zouxxyy (via GitHub)" <gi...@apache.org> on 2025/09/29 03:28:16 UTC
[PR] [core] Add deleted index generation to bucketed dv and hash maintainer [paimon]
Zouxxyy opened a new pull request, #6349:
URL: https://github.com/apache/paimon/pull/6349
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Add deleted index generation to bucketed dv and hash maintainer [paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #6349:
URL: https://github.com/apache/paimon/pull/6349#discussion_r2386615666
##########
paimon-core/src/main/java/org/apache/paimon/compact/CompactDeletionFile.java:
##########
@@ -81,18 +89,20 @@ public CompactDeletionFile mergeOldFile(CompactDeletionFile old) {
throw new IllegalStateException("old should not be get, this is a bug.");
}
- if (deletionFile == null) {
+ if (newDeletionFile == null) {
return old;
}
old.clean();
+ // Keep the old deletion file.
Review Comment:
Here, we should keep the old deletion file
##########
paimon-core/src/main/java/org/apache/paimon/index/DynamicBucketIndexMaintainer.java:
##########
@@ -87,9 +89,11 @@ public List<IndexFileMeta> prepareCommit() {
throw new RuntimeException(e);
}
modified = false;
- return Collections.singletonList(entry);
+ IndexFileMeta toRemove = beforeFile;
Review Comment:
In the streaming scenario, the index maintainer will always hold it and not create it repeatedly, so this logic needs to be added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Add deleted index generation to bucketed dv and hash maintainer [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi closed pull request #6349: [core] Add deleted index generation to bucketed dv and hash maintainer
URL: https://github.com/apache/paimon/pull/6349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org