You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "Daniel Keir Haywood (Jira)" <ji...@apache.org> on 2020/03/19 10:57:00 UTC

[jira] [Updated] (ISIS-2118) Don't redundantly add additional DisabledFacet when disabled at class-level (also fixed in "v1 maintenance")

     [ https://issues.apache.org/jira/browse/ISIS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Keir Haywood updated ISIS-2118:
--------------------------------------
    Summary: Don't redundantly add additional DisabledFacet when disabled at class-level (also fixed in "v1 maintenance")  (was: Don't redundantly add additional DisabledFacet when disabled at class-level.)

> Don't redundantly add additional DisabledFacet when disabled at class-level (also fixed in "v1 maintenance")
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-2118
>                 URL: https://issues.apache.org/jira/browse/ISIS-2118
>             Project: Isis
>          Issue Type: Bug
>    Affects Versions: 1.17.0
>            Reporter: Daniel Keir Haywood
>            Assignee: Daniel Keir Haywood
>            Priority: Minor
>             Fix For: v1 maintenance, 2.0.0-M3
>
>
> using the ISIS-2015 mixin, I see the following for kitchensink's ReferenceObject when annotated as @DomainObject(editing=DISABLED)
> {code}
>             <mml:prop id="otherName">
>                 <mml:facets>
>                     ...
>                     <mml:facet id="org.apache.isis.core.metamodel.facets.members.disabled.DisabledFacet" fqcn="org.apache.isis.core.metamodel.facets.properties.disabled.fromimmutable.DisabledFacetOnPropertyDerivedFromImmutable">
>                         <mml:attr name="disabling">true</mml:attr>
>                         <mml:attr name="inverted">false</mml:attr>
>                         <mml:attr name="semantics">DISABLED</mml:attr>
>                         <mml:attr name="when">ALWAYS</mml:attr>
>                         <mml:attr name="where">ANYWHERE</mml:attr>
>                     </mml:facet>
>                     ...
>                     <mml:facet id="org.apache.isis.core.metamodel.facets.object.immutable.ImmutableFacet" fqcn="org.apache.isis.core.metamodel.facets.object.domainobject.editing.ImmutableFacetForDomainObjectAnnotation">
>                         <mml:attr name="disabling">true</mml:attr>
>                         <mml:attr name="reason">Disabled</mml:attr>
>                         <mml:attr name="when">ALWAYS</mml:attr>
>                     </mml:facet>
> {code}
> The ImmutableFacet isn't required, because the DisabledFacetOnPropertyDerivedFromImmutable should suffice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)