You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/01/31 08:31:15 UTC

[GitHub] storm pull request #1904: STORM-2321 Handle blobstore zk key deletion in Key...

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1904

    STORM-2321 Handle blobstore zk key deletion in KeySequenceNumber

    * If NoNodeException is thrown in getKeySequenceNumber, treat it as KeyNotFoundException
    * Change callers to handle KeyNotFoundException accordingly
    
    Race condition with a deletion is rare case, so instead of adding some locks to prevent race condition, it just allows error and handle it accordingly.
    
    I'll also craft pull request for 1.x branch as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-2321

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1904
    
----
commit ff7204385976e2de8099b5fffa858ae29db8c5a8
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2017-01-31T08:00:31Z

    STORM-2321 Handle blobstore zk key deletion in KeySequenceNumber
    
    * If NoNodeException is thrown in getKeySequenceNumber, treat it as KeyNotFoundException
    * Change callers to handle KeyNotFoundException accordingly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1904: STORM-2321 Handle blobstore zk key deletion in KeySequenc...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/1904
  
    @redsanket I'd really appreciated it if you can take a look. Thanks in advance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #1904: STORM-2321 Handle blobstore zk key deletion in Key...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1904


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #1904: STORM-2321 Handle blobstore zk key deletion in KeySequenc...

Posted by harshach <gi...@git.apache.org>.

Github user harshach commented on the issue:

    https://github.com/apache/storm/pull/1904
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---