You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2017/04/10 08:26:06 UTC

groovy git commit: Minor refactoring and update readme

Repository: groovy
Updated Branches:
  refs/heads/parrot d3fde8da1 -> 5594f294f


Minor refactoring and update readme


Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/5594f294
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/5594f294
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/5594f294

Branch: refs/heads/parrot
Commit: 5594f294fd630503f27786166d65fd2d76898c9c
Parents: d3fde8d
Author: sunlan <su...@apache.org>
Authored: Mon Apr 10 16:25:59 2017 +0800
Committer: sunlan <su...@apache.org>
Committed: Mon Apr 10 16:25:59 2017 +0800

----------------------------------------------------------------------
 subprojects/groovy-parser-antlr4/README.md                       | 2 +-
 .../java/org/apache/groovy/parser/antlr4/GroovydocManager.java   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/groovy/blob/5594f294/subprojects/groovy-parser-antlr4/README.md
----------------------------------------------------------------------
diff --git a/subprojects/groovy-parser-antlr4/README.md b/subprojects/groovy-parser-antlr4/README.md
index 55080e3..c21720e 100644
--- a/subprojects/groovy-parser-antlr4/README.md
+++ b/subprojects/groovy-parser-antlr4/README.md
@@ -11,7 +11,7 @@ The new parser(Parrot) can parse Groovy source code and construct the related AS
 * default method of interface
 * new operators: identity operators(`===`, `!==`), elvis assignment(`?=`), `!in`, `!instanceof`
 * safe index(e.g. `nullableVar?[1, 2]`)
-* groovydoc attached to AST node as metadata
+* runtime groovydoc(i.e. groovydoc with `@Groovydoc`), groovydoc attached to AST node as metadata
 
 **How to enable the new parser**
 * In the gradle build the property useAntlr4 has to be set to enable the build of the parser and the execution of all tests with it. Command line example:

http://git-wip-us.apache.org/repos/asf/groovy/blob/5594f294/subprojects/groovy-parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovydocManager.java
----------------------------------------------------------------------
diff --git a/subprojects/groovy-parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovydocManager.java b/subprojects/groovy-parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovydocManager.java
index 092d73b..20be29d 100644
--- a/subprojects/groovy-parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovydocManager.java
+++ b/subprojects/groovy-parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovydocManager.java
@@ -27,8 +27,8 @@ public class GroovydocManager {
     private static final String EXTRACT_DOC_COMMENT = "groovy.extract.doc.comment";
     private static final String TRUE_STR = "true";
     private static final boolean EXTRACTING_DOC_COMMENT_ENABLED;
-    public static final String VALUE = "value";
-    public static final String RUNTIME_GROOVYDOC_PATTERN = "(?s)/[*][*]\\s+(\\s+[*]\\s*)*@Groovydoc\\b.+?[*]/";
+    private static final String VALUE = "value";
+    private static final String RUNTIME_GROOVYDOC_PATTERN = "(?s)/[*][*]\\s+(\\s+[*]\\s*)*@Groovydoc\\b.+?[*]/";
     private AstBuilder astBuilder;
 
     static {